[patch] xine-ui snapshot build error with lirc

Xavier Bachelot <[email protected]> Thu, 2 Jul 2020 23:20:59 +0200
Newsgroups gmane.comp.video.xine.devel
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------8E24D404CAF4149D8E144A9D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

When building a snapshot of xine-ui (commit 301adf) with lirc support 
enabled, the builds error out with the following :

lirc.c: In function 'lirc_start':
lirc.c:149:3: error: implicit declaration of function 'fcntl' 
[-Werror=implicit-function-declaration]
   149 |   fcntl(lirc.fd, F_SETFD, FD_CLOEXEC);
       |   ^~~~~
lirc.c:149:3: warning: nested extern declaration of 'fcntl' 
[-Wnested-externs]
lirc.c:149:18: error: 'F_SETFD' undeclared (first use in this function)
   149 |   fcntl(lirc.fd, F_SETFD, FD_CLOEXEC);
       |                  ^~~~~~~
lirc.c:149:18: note: each undeclared identifier is reported only once 
for each function it appears in
lirc.c:149:27: error: 'FD_CLOEXEC' undeclared (first use in this function)
   149 |   fcntl(lirc.fd, F_SETFD, FD_CLOEXEC);
       |                           ^~~~~~~~~~
lirc.c:150:18: error: 'F_SETOWN' undeclared (first use in this function)
   150 |   fcntl(lirc.fd, F_SETOWN, getpid());
       |                  ^~~~~~~~
lirc.c:151:26: error: 'F_GETFL' undeclared (first use in this function)
   151 |   flags = fcntl(lirc.fd, F_GETFL, 0);
       |                          ^~~~~~~
lirc.c:153:20: error: 'F_SETFL' undeclared (first use in this function)
   153 |     fcntl(lirc.fd, F_SETFL, flags|O_NONBLOCK);
       |                    ^~~~~~~
lirc.c:153:35: error: 'O_NONBLOCK' undeclared (first use in this function)
   153 |     fcntl(lirc.fd, F_SETFL, flags|O_NONBLOCK);
       |                                   ^~~~~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:934: lirc.o] Error 1


Patch attached.

Regards,
Xavier

--------------8E24D404CAF4149D8E144A9D
Content-Type: text/x-patch; charset=UTF-8;
 name="xine-ui-0.99.12hg301adf-fix_lirc_build.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="xine-ui-0.99.12hg301adf-fix_lirc_build.patch"

# HG changeset patch
# User Xavier Bachelot <[email protected]>
# Date 1593724546 -7200
#      Thu Jul 02 23:15:46 2020 +0200
# Node ID a2361d134f0bc9c755dc63d9d1aa94cfe50bc43f
# Parent  d4fc96ad90263efab9234a34c63feb4c6ad8f3b9
xine-ui: add missing include fcntl.h in xitk/lirc.c

diff -r d4fc96ad9026 -r a2361d134f0b src/xitk/lirc.c
--- a/src/xitk/lirc.c	Thu Jul 02 00:49:48 2020 +0300
+++ b/src/xitk/lirc.c	Thu Jul 02 23:15:46 2020 +0200
@@ -30,6 +30,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 #include <string.h>
+#include <fcntl.h>
 
 #ifdef HAVE_LIRC
 #include <lirc/lirc_client.h>

--------------8E24D404CAF4149D8E144A9D
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--------------8E24D404CAF4149D8E144A9D
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
xine-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-devel

--------------8E24D404CAF4149D8E144A9D--