xine-lib fails to build against ffmpeg 4.5

Xavier Bachelot <[email protected]> Thu, 18 Nov 2021 17:17:03 +0100
Newsgroups gmane.comp.video.xine.devel
Message-ID <[email protected]>
Hi,

xine-lib (both 1.2.11 and a current snapshot) fails to build against a 
snapshot of ffmpeg that will become ffmeg 4.5.

ff_video_decoder.c:64:11: fatal error: libavcodec/vaapi.h: No such file 
or directory
    64 | # include <libavcodec/vaapi.h>
       |           ^~~~~~~~~~~~~~~~~~~~

vaapi.h was deprecated a long time ago and was removed in the following 
commit:
https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/e3d993fab0ad4255dffd10a794fc5e1bd37047b7

Also :
ff_audio_decoder.c: In function 'ff_audio_init_codec':
ff_audio_decoder.c:259:19: warning: assignment discards 'const' 
qualifier from pointer target type [-Wdiscarded-qualifiers]
   259 |       this->codec = avcodec_find_decoder(ff_audio_lookup[i].id);
       |                   ^
ff_audio_decoder.c: In function 'ff_audio_decode':
ff_audio_decoder.c:694:3: warning: 'av_init_packet' is deprecated 
[-Wdeprecated-declarations]
   694 |   av_init_packet (&avpkt);
       |   ^~~~~~~~~~~~~~
In file included from /usr/include/ffmpeg/libavcodec/avcodec.h:45,
                  from ff_audio_decoder.c:37:
/usr/include/ffmpeg/libavcodec/packet.h:503:6: note: declared here
   503 | void av_init_packet(AVPacket *pkt);
       |      ^~~~~~~~~~~~~~

Here's a full build log from the snapshot:
https://koji.rpmfusion.org/kojifiles/work/tasks/3132/513132/build.log

Regards,
Xavier