Re: BadWindow error with compiz-fusion

I demand that George Nychis may or may not have written...

>> First, try current CVS. You should use --enable-debug when running
>> ./configure in case the bug still happens - and if it does, read on...

> It still happens with the current CVS version of xine-lib and xine-ui:

[snip]
> xiTK WARNING(_x_error_handler:258): X error received: 'BadWindow 
> (invalid Window parameter)'
> X Error of failed request:  BadWindow (invalid Window parameter)
>    Major opcode of failed request:  20 (X_GetProperty)
[snip]

>> Enable the gui.synchronize option then quit xine (thus handling the X
>> synchronisation stuff mentioned on that page), restart it via gdb, set a
>> breakpoint on _x_error_handler...
>>   (gdb) run
>>   ...
>>   (gdb) bt
>>   (gdb) info locals
>>   (gdb) info args

> Here we go:

> Breakpoint 1, _x_error_handler (display=0x81424c0, xevent=0xbfb98498)
>      at xitk.c:253
> 253	static int _x_error_handler(Display *display, XErrorEvent *xevent) {
> (gdb) bt
> #0  _x_error_handler (display=0x81424c0, xevent=0xbfb98498) at xitk.c:253
> #1  0xb7d4ebfa in _XError () from /usr/lib/libX11.so.6
> #2  0xb7d506c4 in _XReply () from /usr/lib/libX11.so.6
> #3  0xb7d34886 in XGetWindowProperty () from /usr/lib/libX11.so.6
> #4  0x080dc37b in xitk_check_wm (display=0x81424c0) at xitk.c:501
[snip]
> (gdb) info locals
[snip]

There should have been an "up 4" before that (to get to the right stack
frame) but it's unnecessary - the backtrace is enough and is pointing at the
check for a GNOME-compliant window manager. (The X error doesn't happen here;
but then I'm using xfwm4.)

That said, I've just noticed a type mismatch - try the attached patch (which
should be committed anyway for correctness).

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Use more efficient products. Use less.          BE MORE ENERGY EFFICIENT.

I'm not under the alkafluence of inkahol that some thinkle peep I am.

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

_______________________________________________
xine-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xine-user

Index: src/xitk/xine-toolkit/xitk.c
===================================================================
RCS file: /cvsroot/xine/xine-ui/src/xitk/xine-toolkit/xitk.c,v
retrieving revision 1.162
diff -u -r1.162 xitk.c
--- src/xitk/xine-toolkit/xitk.c	13 Nov 2007 21:12:21 -0000	1.162
+++ src/xitk/xine-toolkit/xitk.c	28 Nov 2007 14:35:40 -0000
@@ -494,7 +494,7 @@
 	unsigned char   *prop_return2 = NULL;
 	Window           win_id;
 	
-	win_id = *(unsigned long *)prop_return;
+	win_id = *(Window *)prop_return;
 	
 	xitk_install_x_error_handler();