Re: NASM errors when compiling under Windows

Okay, the patched files can be found at
[http://www.club.cc.cmu.edu/~cort/xvidcore-nasm-patch.zip].  Unzip it
into the main xvidcore directory, and the patched files will be:
 - build/win32/libxvidcore-new.dsp
 - build/win32/libxvidcore-new.vcproj
 - build/win32/libxvidcore_static-new.dsp

A disclaimer: I only have access to Visual Studio 2008, so I was unable
to directly test these files myself (since they're in the MSVC 6.0 and
MSVC 2005 formats).  I just made the appropriate modifications with a
text editor.  It should be quite easy to determine whether the fix is
working, though; just move the xvidcore directory to a path with a space
in it and try to build.

Thanks, let me know if I missed anything!
 - cort

Michael Militzer wrote:
> > Hi,
> >
> > indeed, path names containing spaces could be a problem with Visual C.
> >
> > You should create a patch with your proposed changes and post it
here. It
> > will then be commited to CVS after review.
> >
> > Note that the list strips attachments for security reasons. So you
should
> > either upload your patch somewhere and just post a link to the list or
> > paste your patch into the body of your mail.
> >
> > Thanks,
> > Michael
> >
> >
> > Quoting Cort Danger Stratton <[email protected]>:
> >
>> >> Hello,
>> >>
>> >> Whenever I download a new xvidcore source archive and try to build it
>> >> under Windows, I invariably run into some NASM-related build
errors ("no
>> >> input file provided", "more than one input file provided", that
sort of
>> >> thing).  The problem seems to that certain Visual Studio path macros,
>> >> like $(InputDir), are being passed to NASM without quotes.  If the
path
>> >> name contains spaces or other special characters, nasm interprets
it as
>> >> multiple strings, and errors generally ensue.
>> >>
>> >> I was able to fix the problems by replacing the Custom Build Step for
>> >> all *.asm files in the project with the following command:
>> >>
>> >>     nasm -o "$(IntDir)\$(InputName).obj" -f win32 -DWINDOWS
-I..\..\src\
>> >>         -I"$(InputDir)\" "$(InputPath)"
>> >>
>> >> Note especially the trailing backslash after $(InputDir) on the second
>> >> line; if it is not present, and if $(InputDir) ends in a backslash
>> >> (which it most often does), Visual Studio seems to ignore the trailing
>> >> double-quote and confuse itself even further.
>> >>
>> >> It would be great if this fix could make it into CVS; I'd be happy
to do
>> >> it myself, if somebody could explain how that process works (I'm a new
>> >> subscriber; I don't know the rules yet).
>> >>
>> >> Thanks!
>> >>  - cort
>> >> _______________________________________________
>> >> Xvid-devel mailing list
>> >> [email protected]
>> >> http://list.xvid.org/mailman/listinfo/xvid-devel
>> >>
>> >>
> >
> >
> >
> > _______________________________________________
> > Xvid-devel mailing list
> > [email protected]
> > http://list.xvid.org/mailman/listinfo/xvid-devel
> >
> >
> > !DSPAM:4948bc2c41716105090283!
> >