Re: Questions / Bug fixes / Patches

Greetings,
         But i don't think my patch was applied, should it be applied? Have you confirmed that it causes problems in some players or not? On my side, I thoughr it would cause problems (I am converting the Xvid streams to MP4 streams using mp4box, but it seems after testing that i could not reproduce the problem...

Best regards,
Carl

--- On Fri, 8/27/10, Marcin Jaworski <[email protected]> wrote:

> From: Marcin Jaworski <[email protected]>
> Subject: Re: [XviD-devel] Questions / Bug fixes / Patches
> To: [email protected]
> Received: Friday, August 27, 2010, 3:09 PM
> 
> > Sorry, I forgot to include line 264 of encoder.c in
> the patch I posted.
> > It was copy'n'paste from a larger patch. Here's a
> corrected patch: 
> > http://pastebin.com/Sq2uPiHj
> >
> > I've been using something like that for months and it
> seems to work 
> > perfectly (even with artificially created dupes that
> otherwise caused 
> > N-VOPs).
> >
> > Line 1178 of encoder.c uses frame_drop_ratio == -1 to
> force a coded VOP 
> > (it causes the "<=" in line 1887 to be always
> false, which results in a 
> > coded VOP). Hence my conclusion about "-1" ;-)
> >
> > So it's not really an official part of the API, but
> just a hack. Thank 
> > you for clearing that up.
> >
> > Best regards,
> > Marcin Jaworski
> > _______________________________________________
> >
> >   
> Nevermind... Now I read Carl's patch through the WWW
> archive of the 
> mailing list (I didn't receive some of the posted messages
> through 
> e-mail - I guess it's time to use a better mail account). I
> see that his 
> method is quite similar to the one I've been using for some
> time now. 
> Sorry for the confusion.
> 
> Best regards,
> Marcin Jaworski
> _______________________________________________
> Xvid-devel mailing list
> [email protected]
> http://list.xvid.org/mailman/listinfo/xvid-devel
>