Re: [PATCH] Initialize p_fmv.x

Hi,

indeed, this appears to be a typo. Patch applied. Thanks.

Best regards,
Michael


Quoting Lasse Collin <[email protected]>:

> GCC gives the following warning:
>
>     ../../src/decoder.c:1663:46: warning: operation on `dec->p_fmv.y'
>     may be undefined
>
> It looks like a typo in the code (p_fmv.y is mentioned twice):
>
>     dec->p_bmv.x = dec->p_bmv.y = dec->p_fmv.y = dec->p_fmv.y = 0;    
> /* init pred vector to 0 */
>               ^^^            ^^^            ^^^            ^^^
>
> --- xvid_20101108.orig/xvidcore/src/decoder.c	2010-08-10   
> 18:00:34.000000000 +0300
> +++ xvid_20101108/xvidcore/src/decoder.c	2010-11-08 14:18:40.736668331 +0200
> @@ -1660,7 +1660,7 @@
>      goto repeat;
>    }
>
> -  dec->p_bmv.x = dec->p_bmv.y = dec->p_fmv.y = dec->p_fmv.y = 0;    
> /* init pred vector to 0 */
> +  dec->p_bmv.x = dec->p_bmv.y = dec->p_fmv.x = dec->p_fmv.y = 0;    
> /* init pred vector to 0 */
>
>    /* packed_mode: special-N_VOP treament */
>    if (dec->packed_mode && coding_type == N_VOP) {
>
> --
> Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode
> _______________________________________________
> Xvid-devel mailing list
> [email protected]
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
>