Re: Patch to correct cross building

Hi,

indeed, ar should not be hardcoded. Patch applied.

Thanks,
Michael


Quoting Bin Tian <[email protected]>:

> hi,
>
> The ar tool is hardcoded in build/generic/Makefile, so it maybe produce
> incorrect archive file when cross building.
>
> The following patch based on 1.3.0-rc1 will correct it.
>
> Regards,
> Bin Tian
>
> diff -Naur xvidcore.old/build/generic/configure.in
> xvidcore.new/build/generic/configure.in
> --- xvidcore.old/build/generic/configure.in     2010-12-31
> 18:53:22.000000000 +0800
> +++ xvidcore.new/build/generic/configure.in     2011-01-11
> 09:30:07.576266001 +0800
> @@ -128,6 +128,7 @@
>   dnl
> ==========================================================================
>
>   AC_PROG_RANLIB
> +AC_CHECK_TOOL([AR], [ar], [ar-not-found])
>
>   dnl
> ==========================================================================
>   dnl
> @@ -689,6 +690,7 @@
>   AC_SUBST(DCT_IA64_SOURCES)
>   AC_SUBST(PPC_ALTIVEC_SOURCES)
>   AC_SUBST(RANLIB)
> +AC_SUBST(AR)
>   AC_SUBST(API_MAJOR)
>   AC_SUBST(API_MINOR)
>   AC_SUBST(STATIC_LIB)
> diff -Naur xvidcore.old/build/generic/Makefile
> xvidcore.new/build/generic/Makefile
> --- xvidcore.old/build/generic/Makefile 2010-12-31 18:53:22.000000000 +0800
> +++ xvidcore.new/build/generic/Makefile 2011-01-11 09:30:30.776266000 +0800
> @@ -111,7 +111,7 @@
>
>   $(STATIC_LIB): $(BUILD_DIR) $(OBJECTS)
>          @echo "  L: $(@F)"
> -       @cd $(BUILD_DIR) && ar rc $(@F) $(OBJECTS) && $(RANLIB) $(@F)
> +       @cd $(BUILD_DIR) && $(AR) rc $(@F) $(OBJECTS) && $(RANLIB) $(@F)
>
>
> #-----------------------------------------------------------------------------
>   # Shared Library
> diff -Naur xvidcore.old/build/generic/platform.inc.in
> xvidcore.new/build/generic/platform.inc.in
> --- xvidcore.old/build/generic/platform.inc.in  2010-12-31
> 18:53:22.000000000 +0800
> +++ xvidcore.new/build/generic/platform.inc.in  2011-01-11
> 09:31:38.964266001 +0800
> @@ -50,6 +50,7 @@
>   API_MAJOR=@API_MAJOR@
>   API_MINOR=@API_MINOR@
>   RANLIB=@RANLIB@
> +AR=@AR@
>
>   #
> ============================================================================
>   # Installation
> _______________________________________________
> Xvid-devel mailing list
> [email protected]
> http://list.xvid.org/mailman/listinfo/xvid-devel
>
>