Re: Patch for XVID MPEG-4 DirectShow/MediaFoundation filter

Jerker Bäck <[email protected]> Mon, 13 Jun 2011 18:48:54 +0200
Newsgroups gmane.comp.video.xvid.devel
Message-ID <[email protected]>
Some other views that I can think of is that the _T() macro would be an
easier patch and require less changes. Making the source robust in respect
to the UNICODE define and __stdcall calling convention (e.g. a WDK compile)
would be a GOOD thing in any case. My gut tells me though that the code
style and overall project appearance would be more consistent with my
suggestion. A UNIX developer would have no clue of these things.

I assume that the current requirement for an ANSI/__cdecl compile is due to
UNIX conventions and compatibility with e.g. the mingw compiler. Keeping it
simple would help in this respect too.