Re: Not tracing UDP responses

Lionel,

Very cool!  I look forward to your patch! I am presently cleaining 
things up would be nice to have a fix to that problem. Do test to make 
sure there is no double logging :-) . Also make sure that the patch is 
for the JAIN-SIP 1.2 latest version that you get from the cvs repository 
on the NIST  (is2.antd.nist.gov) machine (not the repository on 
java.net). Once everything is nice and clean , the repository will be 
moved to java.net and I shall acknowledge your contribution.

Note that the proxy is in a mess at present. I am hacking on that too.

Regards

Ranga



MALLET Lionel wrote:

> 
>Hello Jeroen,
>
>Initiallly I thoug that nothing was missing as I could  find a call to
>log the response in the SIPClientTransaction class. But eventually, I
>traced down the processMessage() method of the TCPMessageChannel to
>determine what was done for a response and I figured out that the
>missing call was in the NistSipHandlerImpl class. I will provide a patch
>to Ranga soon.
>
>BTW, the responses that weren't traced were the ones received by the
>proxy, not the ones it generated. It seems to me that  with your fix
>only the proxy generated ones will be traced. But I'm still new to the
>code so I may be wrong.
>
>Regards,
>________________________________
>
>	Lionel Mallet - Gemalto
>	Tel: +33 (0)4 42 36 59 70
>
>
>-----Original Message-----
>From: Jeroen van Bemmel [mailto:[email protected]] 
>Sent: jeudi 15 juin 2006 18:32
>To: M. Rangnathan; MALLET Lionel
>Cc: [email protected]
>Subject: Re: [nist-sip] Not tracing UDP responses
>
>Lionel,
>
>A while ago I changed some code having to do with response logging. I
>too had the problem that responses weren't showing up, the logging call
>is in SIPTransactionStack newSIPServerResponse line 877
>
>It could be that I missed some code paths...
>
>Regards,
>
>jeroen
>
>----- Original Message -----
>From: "M. Rangnathan" <[email protected]>
>To: "MALLET Lionel" <[email protected]>
>Cc: <[email protected]>
>Sent: Thursday, June 15, 2006 12:24 PM
>Subject: Re: [nist-sip] Not tracing UDP responses
>
>
>  
>
>>Lionel,
>>
>>Sure! Go ahead and make a patch for UDPMessageChannel in  JAIN-SIP-1.2
>>    
>>
>and 
>  
>
>>send it to me. I will apply it.  Alternatively you can modify the file
>>    
>>
>and 
>  
>
>>just send me the entire file. I will generate the diff and apply it.
>>    
>>
>That 
>  
>
>>omission has been sitting for a while.
>>
>>Thanks
>>
>>Ranga
>>
>>MALLET Lionel wrote:
>>
>>    
>>
>>>I think I have not found the reason why some Response messages are
>>>      
>>>
>not 
>  
>
>>>traced in server_log.txt (see my previous post on missing 202
>>>      
>>>
>response 
>  
>
>>>from SUBSCRIBE).
>>> In gov.nist.javax.sip.stack.UDPMessageChannel:run(), there is call
>>>      
>>>
>to 
>  
>
>>>logMessage when the sipMessage is of type SIPRequest, but nothing
>>>      
>>>
>similar 
>  
>
>>>when it is a SIPResponse. I wonder if this is done on purpose or if I
>>>      
>>>
>can 
>  
>
>>>safely add that call for the latter?
>>> Thx for your advice.
>>>
>>>      
>>>
>------------------------------------------------------------------------
>  
>
>>>    *Lionel Mallet/ - Gemalto/*
>>>    Tel: +33 (0)4 42 36 59 70
>>>
>>>----------------------------------------------------------------------
>>>      
>>>
>--
>  
>
>>>_______________________________________________
>>>nist-sip mailing list
>>>[email protected]
>>>http://www-x.antd.nist.gov/mailman/listinfo/nist-sip
>>>
>>>      
>>>
>>-- 
>>M. Ranganathan
>>Advanced Networking Technologies Division,
>>National Institute of Standards and Technology (NIST),
>>100 Bureau Drive, Stop 8920, Gaithersburg, MD 20899. tel:301 975 3664
>>    
>>
>, 
>  
>
>>fax:301 590 0932 http://w3.antd.nist.gov/
>>Advanced Networking Technologies For the People!
>>
>>
>>_______________________________________________
>>nist-sip mailing list
>>[email protected]
>>http://www-x.antd.nist.gov/mailman/listinfo/nist-sip 
>>    
>>
>
>
>
>_______________________________________________
>nist-sip mailing list
>[email protected]
>http://www-x.antd.nist.gov/mailman/listinfo/nist-sip
>
>  
>


-- 
M. Ranganathan 

Advanced Networking Technologies Division,
National Institute of Standards and Technology (NIST),
100 Bureau Drive, Stop 8920, Gaithersburg, MD 20899. 
tel:301 975 3664 , fax:301 590 0932 http://w3.antd.nist.gov/
Advanced Networking Technologies For the People!