RE: Why are the header classes final?
Jeroen Van Bemmel <[email protected]>
| Newsgroups | gmane.comp.voip.nist-sip |
|---|---|
| Message-ID | <[email protected]> |
Ranga, IMHO changing the default to non-quoted, to accomodate some broken proxy implementation, is a bad idea. It will break support for special characters in displayname (like accents). In a quoted string only quotes and backslashes need escaping (using \), else you need more complex %-encoding. This reminds me: we should ask some people that speak e.g. Chinese, to test if their names are handled properly Regards, Jeroen -----Oorspronkelijk bericht ----- Van: "M. Ranganathan" <[email protected]> Aan: "Jeroen van Bemmel" <[email protected]> CC: "M. Rangnathan" <[email protected]>; [email protected]; [email protected] Verzonden: 9-11-06 15:43 Onderwerp: Re: [nist-sip] Why are the header classes final? Hmmm... ;learn something new every day. I never knew that non final classes would degrade performance. Thanks for the tip! Jeroen is correct in that there could well be class cast exceptions generated as well. A bit of experimentation would help determine this is indeed true. The one concern I had was that equals would break but Jeroen has converted all equals to to use the interface directly and not the class ( thus making the tck work across implementations - which is highly desirable :-) ). Now that I am aware of the performance implications, I will go ahead and convert this and all other header classes back to final because indeed performance is a very important consideration. To make a long story short. I suppose what I could do is be gentle about encoding Display Name strings and not put the quotes around the String if the String has no white spaces (but just for display name). Please bring up this issue in the Asterisk mailing list if indeed this is the problem because the quotes should not matter. David, please experiment and report back to this list. Does removing the quotes work for you? Regards, Ranga Jeroen van Bemmel wrote: