Re: Re: IMS contribution
"M. Ranganathan" <[email protected]> Tue, 12 Dec 2006 14:48:21 -0500
| Newsgroups | gmane.comp.voip.nist-sip |
|---|---|
| Organization | NIST Advanced Networking Technologies Division |
| Message-ID | <[email protected]> |
Jeroen, OK. Thanks for informing. I fixed the problem ( well, at least I did an unset CLASSPATH and tried ant complieri and compiletck and it seems to be OK now). Miguel, OK please go ahead and change names if you wish. Please use the current version and change its name so as to keep the latest changes (if any) intact. Please go ahead and commit after running tck and I'll announce your contribution on the list (which I have already done in effect :-) ). Thanks for writing up an example. Regards, Ranga On Tue, 2006-12-12 at 20:13 +0100, Jeroen van Bemmel wrote: > Specifically, I need to do this for 'ant runtck'. Build target works > > Jeroen > ----- Original Message ----- > From: Jeroen van Bemmel > To: Miguel Freitas ; M. Ranganathan > Cc: [email protected] > Sent: Tuesday, December 12, 2006 7:10 PM > Subject: Re: [nist-sip] Re: IMS contribution > > > I always have to do 'set CLASSPATH=lib/junit-x.x.x.jar' to get > it to build under ant (from a commandline window) > > Jeroen > ----- Original Message ----- > From: Miguel Freitas > To: M. Ranganathan > Cc: [email protected] > Sent: Tuesday, December 12, 2006 6:17 PM > Subject: [nist-sip] Re: IMS contribution > > > > On 12/12/06, M. Ranganathan <[email protected]> wrote: > Hi Miguel, > > > I really cant figure out the reasons for your > compile problems. I just > checked out a fresh copy and I still have no > problems. Does anybody else > on this list have such problems? Clearly, its > because you dont have > junit in your class path but why? It does not > seem to be an issue for > me. > > Yes, it seams to be a class path issue to ant, since > junit.framework.* is accessible inside Eclipse. > Is there other way to compile the parser tests? > Silly question but.. Is there anything I have to > install on my system or put in the system CLASSPATH? > > The "compileunit" target does not include, like for eg > "compiletck" does: > <classpath> > <pathelement > location='${junit_jar}' /> > </classpath> > could this issue be related to it? > > > -> P-Headers names changed to include a > leading "P". eg: > PAccessNetworkInfoHeader.java > > Any reason for the class name changes? It > could cause issues with > people that are already using your > contributions. > > I know it's not a developer-friendly decision, and not > a so good policy to change stuff names after > deployment, but I think that sooner or later someone > will want to change those names since their real name > includes a leading "P". > I share most of the responsibility on that issue, and > I should had changed it as soon as I started working > on them and before their first submission. > But that's my humble opinion. What do you think? > > > > A small nit: can you also please fix the > javadoc errors in your code > ( there are some from the previous > contributions you made). > > Yes, of course. Is being taking care of. > > > Thanks for adding the unit tests. Your > contribution would be a good > basis to pattern IMS headers for JSIP 1.3. > > Best regards, > > Ranga. > > > > On Tue, 2006-12-12 at 15:54 +0000, Miguel > Freitas wrote: > > > > sorry, I forgot to change the subject :) > > > > On 12/12/06, M. Ranganathan > <[email protected]> wrote: > > > > > > Hi Miguel, > > > > I look forward to your > contributions! > > > > I managed to include the changes in a recent > CVS source code version > > and I'm just concluding the parser tests and > a simple example for the > > usage of the new headers. Hence my need to > compile the unit tests. > > > > Here's a list of my changes, please let me > know if at this point you > > might not agree with any of them.. > > > > ----------------------------------------- > > .: changes in JAIN-SIP RI > > ----------------------------------------- > > > > -> changes in > gov.nist.core.NameListCore.java > > . white space added between the several > parameters encoding > > > > -> added > gov.nist.javax.sdp.fields.PreconditionFields.java > > -> changes in > gov.nist.sdp.MediaDescriptionImpl.java > > . changed BandwithField logic > > . PUBLIC addAttribute(AttributeField > af) > > - is there other way to add > several SDP attributes with > > the same name to the same Media Description? > > eg: m=video 00 RTP/AVP 98 > 99 > > a=rtpmap:98 H263 > > a=rtpmap:99 MP4V-ES > > > > -> P-Headers names changed to include a > leading "P". eg: > > PAccessNetworkInfoHeader.java > > > > -> changes in > gov.nist.javax.sip.header.ims.ParametersNamesIms.java > > > > -> changes in > gov.nist.javax.sip.header.ims.SIPHeaderNamesIms.java > > > > -> added > gov.nist.javax.sip.header.ims.SecurityAgree.java > > -> added > gov.nist.javax.sip.header.ims.SecurityAgreeHeader.java > > -> added > gov.nist.javax.sip.header.ims.SecurityClient.java > > -> added > gov.nist.javax.sip.header.ims.SecurityClientList.java > > -> added > gov.nist.javax.sip.header.ims.SecurityClientHeader.java > > -> added > gov.nist.javax.sip.header.ims.SecurityServer.java > > -> added > gov.nist.javax.sip.header.ims.SecurityServerList.java > > -> added > gov.nist.javax.sip.header.ims.SecurityServerHeader.java > > -> added > gov.nist.javax.sip.header.ims.SecurityVerify.java > > -> added > gov.nist.javax.sip.header.ims.SecurityVerifyList.java > > -> added > gov.nist.javax.sip.header.ims.SecurityVerifyHeader.java > > > > -> changes in > gov.nist.javax.sip.header.HeaderFactoryImpl.java > > > > -> changes in > gov.nist.javax.sip.header.NameMap.java > > > > -> changes in > gov.nist.javax.sip.message.ListMap.java > > > > -> changes in > gov.nist.javax.sip.parser.ParserFactory.java > > > > -> changes in > gov.nist.javax.sip.parser.Lexer.java > > > > -> changes in > gov.nist.javax.sip.parser.TokenTypes.java > > > > -> added > gov.nist.javax.sip.parser.PAssociatedURIParser.java > > -> added > gov.nist.javax.sip.parser.PCalledPartyIDParser.java > > -> added > gov.nist.javax.sip.parser.SecurityAgreeParser.java > > -> added > gov.nist.javax.sip.parser.SecurityClientParser.java > > -> added > gov.nist.javax.sip.parser.SecurityServerParser.java > > -> added > gov.nist.javax.sip.parser.SecurityVerifyParser.java > > > > -> added > unit.gov.nist.javax.sip.parser.ims.* > > -> added > unit.gov.nist.javax.sip.parser.ims.SecurityClientTest.java > > -> added > unit.gov.nist.javax.sip.parser.ims.SecurityServerTest.java > > ... > > > > -> added examples.ims.* > > . based on examples.simplecallsetup > > > > > > ----------------------------------------- > > .: changes in proprietary JAIN-SIP API > > ----------------------------------------- > > > > -> changes in > javax.sdp.MediaDescription.java > > . methods for PreconditionFields > > . PUBLIC addAttribute(AttributeField af) > > > > > > > > > > Miguel Freitas > > -- > > - - - - > - - - - > > - Telecommunications Institute - > > - Instituto de Telecomunicacoes - > > - Aveiro, Portugal - > > - > www.it.pt - > > - - - - > - - - - > > > > > > -- > > - - - - > - - - - > > - Telecommunications Institute - > > - Instituto de Telecomunicacoes - > > - Aveiro, Portugal - > > - > www.it.pt - > > - - - - > - - - - > > > > > -- > - - - - - - - - > - Telecommunications Institute - > - Instituto de Telecomunicacoes - > - Aveiro, Portugal - > - www.it.pt - > - - - - - - - - > > > ______________________________________________________ > > _______________________________________________ > nist-sip mailing list > [email protected] > http://www-x.antd.nist.gov/mailman/listinfo/nist-sip > > > ______________________________________________________________ > > _______________________________________________ > nist-sip mailing list > [email protected] > http://www-x.antd.nist.gov/mailman/listinfo/nist-sip