Re: hfl not working as well

Hi,
Succeed to recompile, the patch seems working well,
I will test many cases to see that cover all cases.
Thank you very much for your Help

On Fri, Jun 13, 2025 at 3:36 PM Daniel-Constantin Mierla <[email protected]>
wrote:

> If you want help, considering that it is done on spare time/volunteering,
> try as instructured with a clean git master branch, that is the version
> that has the fix. If not working, send the output of the kamailio -v and
> the full sip message you use for testing and it does not work.
>
> Cheers,
> Daniel
> On 13.06.25 14:01, ale Gural wrote:
>
> Hi, did it, even make clean before but nothing change,
> Strange.
>
> בתאריך יום ו׳, 13 ביוני 2025, 14:32, מאת Henning Westerholt ‏<
> [email protected]>:
>
>> Hello,
>>
>>
>>
>> not sure how you compiled the kamailio, but you can e.g. execute “make
>> clean; make” in the source directory and it should compile all again.
>>
>>
>>
>> Refer to e.g. this:
>> https://www.kamailio.org/wikidocs/devel/makefile-system/ for the old
>> make system.
>>
>>
>>
>> Cheers,
>>
>>
>>
>> Henning
>>
>>
>>
>> *From:* ale Gural via sr-users <[email protected]>
>> *Sent:* Friday, June 13, 2025 10:57 AM
>> *To:* [email protected]
>> *Cc:* Kamailio (SER) - Users Mailing List <[email protected]>;
>> ale Gural <[email protected]>
>> *Subject:* [SR-Users] Re: hfl not working as well
>>
>>
>>
>> Hi,
>>
>> It seems that didn't compile the new file, added in the parse_diversion.c
>> file some log, but not show it in kamailio.log
>>
>> after compile got:
>>
>>
>>
>> version: kamailio 5.8.6 (x86_64/linux) fb71db
>>
>> flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS,
>> DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE,
>> Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX,
>> FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR,
>> USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
>>
>> ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144,
>> MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT
>> PKG_SIZE 8MB
>>
>> poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
>>
>> id: fb71db
>>
>> compiled on 11:43:38 Jun 13 2025 with gcc 11.4.1
>>
>>
>>
>> I  am still trying to understand why not replace the old file,
>>
>> if you have any Idea why, appreciate your help.
>>
>>
>>
>> Thanks!
>>
>>
>>
>> On Fri, Jun 13, 2025 at 9:34 AM Daniel-Constantin Mierla <
>> [email protected]> wrote:
>>
>> I tested during development and worked fine with your example header. Do
>> try with the development version to validate it or not, send kamailio -v if
>> still fails along with the entire sip message used during your tests.
>>
>> Cheers,
>> Daniel
>>
>> On 12.06.25 19:37, ale Gural wrote:
>>
>> Thanks for your quick response,
>>
>> I replaced the new file parser_diversion.c in /src/core/parser/ and
>> compiler again, same result.
>>
>>
>>
>> Thanks!
>>
>>
>>
>> On Thu, Jun 12, 2025 at 6:48 PM Daniel-Constantin Mierla <
>> [email protected]> wrote:
>>
>> Can you try with latest git master branch? I pushed a commit trying to
>> fix it, the problem was in the way the parser computed the length of the
>> Diversion value, not considering quoted values.
>>
>> Cheers,
>> Daniel
>>
>> On 12.06.25 11:25, ale Gural via sr-users wrote:
>>
>> ale Gural
>>
>> 12:24 PM (0 minutes ago)
>>
>> to Benoit
>>
>> I am using KAMAILIO 5.8.6,
>>
>> Diversion:"Ale Gural"<sip:[email protected]
>> ;user=phone>;reason=unconditional;privacy=off;counter=1;user-id="
>> [email protected]"
>>
>> when I use the $(hfl(Diversion)[0]) I got
>>
>> Diversion:"Ale Gural"<sip:[email protected]
>> ;user=phone>;reason=unconditional;privacy=off;counter=1;user-id="
>> [email protected]
>>
>> Is a Bug?
>>
>>
>>
>> Thanks!
>>
>>
>>
>> On Thu, Jun 12, 2025 at 12:04 PM Benoit Panizzon <[email protected]>
>> wrote:
>>
>> Hi
>>
>> > Does anyone know why using $(hfl(Diversion)[0]) cuts off the last part
>> of
>> > the value, while hdr doesn't?
>>
>> $hfl tries to de-serialize comma (and probably semicolon) separated one
>> line header. So maybe it stumbles over something which causes it to
>> believe the last part belongs to another header?
>>
>> Is he missing part in [1]?
>> What does the complete Diversion header causing the issue look like?
>>
>> Mit freundlichen Grüssen
>>
>> -Benoît Panizzon-
>> --
>> I m p r o W a r e   A G    -    Leiter Commerce Kunden
>> ______________________________________________________
>>
>> Zurlindenstrasse 29
>> <https://www.google.com/maps/search/Zurlindenstrasse+29?entry=gmail&source=g>
>>            Tel  +41 61 826 93 00
>> CH-4133 Pratteln                Fax  +41 61 826 93 01
>> Schweiz                         Web  http://www.imp.ch
>> ______________________________________________________
>>
>>
>>
>> __________________________________________________________
>>
>> Kamailio - Users Mailing List - Non Commercial Discussions -- [email protected]
>>
>> To unsubscribe send an email to [email protected]
>>
>> Important: keep the mailing list in the recipients, do not reply only to the sender!
>>
>> --
>>
>> Daniel-Constantin Mierla (@ asipto.com)
>>
>> twitter.com/miconda -- linkedin.com/in/miconda
>>
>> Kamailio Consultancy, Training and Development Services -- asipto.com
>>
>> Kamailio Scalability Training - Online, June 16-19, 2025 -- asipto.com
>>
>> --
>>
>> Daniel-Constantin Mierla (@ asipto.com)
>>
>> twitter.com/miconda -- linkedin.com/in/miconda
>>
>> Kamailio Consultancy, Training and Development Services -- asipto.com
>>
>> Kamailio Scalability Training - Online, June 16-19, 2025 -- asipto.com
>>
>> --
> Daniel-Constantin Mierla (@ asipto.com)twitter.com/miconda -- linkedin.com/in/miconda
> Kamailio Consultancy, Training and Development Services -- asipto.com
> Kamailio Scalability Training - Online, June 16-19, 2025 -- asipto.com
>
>

__________________________________________________________
Kamailio - Users Mailing List - Non Commercial Discussions -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the sender!