Re: pull request planned for htable module
Groissenberger David via sr-users <[email protected]> Fri, 29 May 2026 10:25:58 +0000
| Newsgroups | gmane.comp.voip.ser |
|---|---|
| Message-ID | <DB9PR10MB738743C7AF59F01BB8F7109F95162@DB9PR10MB7387.EURPRD10.PROD.OUTLOOK.COM> |
Hello, thanks a lot for the feedback. The idea of htable.help was not to replace the existing RPC help functionality, but to provide a compact overview of the available htable RPC commands. The existing `help htable.get` / `help htable.seti` style works well if the user already knows the exact command and parameters. The additional `htable.help` command is meant more as a command list, showing the available htable commands with short usage hints in one place. For example, `kamcmd htable.help` Looks somewhat like this: htable.get <table> <key> htable.sets <table> <key> <string_value> htable.seti <table> <key> <int_value> htable.dump <table> [<path>] htable.store <table> It also supports a more detailed output for a specific htable command, for example: kamcmd htable.help htable.dump This prints the usage, description, parameters, notes and examples for that command. It is intended for easier command usage directly from kamcmd, without checking the documentation first. If this does not fit the usual RPC style in Kamailio, I can drop `htable.help` from the Pull-request and only extend the standard RPC help texts for the new/changed commands. I will make a pull request with the changes. Cheers, David Von: Henning Westerholt <[email protected]> Gesendet: Donnerstag, 28. Mai 2026 22:03 An: Kamailio (SER) - Users Mailing List <[email protected]> Cc: Groissenberger David <[email protected]>; Onic Roman <[email protected]>; Valentin Christoph <[email protected]> Betreff: RE: pull request planned for htable module Some people who received this message don't often get email from [email protected]<mailto:[email protected]>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> (email got send by mistake in parts) Like this: kamcmd> help htable.seti Set one key in a hash table to an integer value. kamcmd> help htable.get Get one key from a hash table. What functionality does the htable.help provide? Cheers, Henning From: Henning Westerholt Sent: Donnerstag, 28. Mai 2026 22:02 To: 'Kamailio (SER) - Users Mailing List' <[email protected]<mailto:[email protected]>> Cc: Groissenberger David <[email protected]<mailto:[email protected]>>; Onic Roman <[email protected]<mailto:[email protected]>>; Valentin Christoph <[email protected]<mailto:[email protected]>> Subject: RE: pull request planned for htable module Hello, Thank you for the question and your interest in improving kamailio. Usually, the best way to review changes is in a pull-request. I am not the author of the htable module, but if the changes are not breaking or negatively affecting existing functionality in a module they are usually accepted after a review and possible adaptions. Quick question about the htable.help command – usually the help is implemented directly in the RPC command, e.g.: From: Valentin Christoph via sr-users <[email protected]<mailto:[email protected]>> Sent: Donnerstag, 28. Mai 2026 12:03 To: Kamailio (SER) - Users Mailing List <[email protected]<mailto:[email protected]>> Cc: Groissenberger David <[email protected]<mailto:[email protected]>>; Onic Roman <[email protected]<mailto:[email protected]>>; Valentin Christoph <[email protected]<mailto:[email protected]>> Subject: [SR-Users] pull request planned for htable module Hi all, We have implemented a few improvements/additions around the htable RPC commands for our own purposes, mainly to support runtime configuration, export/import and persistence handling for htable data. Most of the changes are: • New ‘htable.help’ command • Support for dumping htable content to a file – via ‘htable.dump <table> [path]’ • New ‘htable.load_from_file’ command to load htable entries from a file • Support for ‘htable.store all’ and ‘htable.store all force’ Since the changes are relatively large and require some documentation updates, we wanted to ensure first whether these kinds of changes are wanted for Kamailio. Any hint is welcome. Kind regards, Christoph __________________________________________________________ Kamailio - Users Mailing List - Non Commercial Discussions -- [email protected] To unsubscribe send an email to [email protected] Important: keep the mailing list in the recipients, do not reply only to the sender!