bug in RandomPageModuleMixin.load_page

--0016e6db2999edb2e50486925792
Content-Type: text/plain; charset=UTF-8

Hi all!

load_page method of RandomPageModuleMixin seems to have a bug. If URL
has dots this method doesn't catch ApplicationError correctly, and
server returns 500 error instead of 404.

Traceback is following:

2010-04-07 17:37:32.215924: //phpMyAdmin/config/config.inc.php?c=uptime
Traceback (most recent call last):
  File "/var/www/ivi/website/modules/app.py", line 167, in run
    self.load_page(ctx)
  File "/usr/lib/python2.5/site-packages/albatross/randompage.py",
line 29, in load_page
    self.load_page_module(ctx, page)
  File "/usr/lib/python2.5/site-packages/albatross/app.py", line 437,
in load_page_module
    raise ApplicationError('%s (in %s)' % (e, mod_dir))
ApplicationError: No module named php (in
/var/www/ivi/website/pages/config/config/inc)

This can be easily fixed with attached patch.

-- 
Best regards,
Nickolay S. Savchenko

--0016e6db2999edb2e50486925792
Content-Type: text/x-patch; charset=US-ASCII; name="load_page.patch"
Content-Disposition: attachment; filename="load_page.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g97d3q9i0

LS0tIHJhbmRvbXBhZ2UucHkub3JpZwkyMDEwLTA1LTE0IDIxOjQ2OjUzLjE4MzA4MDM5OSArMDMw
MAorKysgcmFuZG9tcGFnZS5weQkyMDEwLTA1LTE0IDIxOjQ3OjA5LjkxMzA3NDU2OCArMDMwMApA
QCAtMjgsNyArMjgsNyBAQAogICAgICAgICB0cnk6CiAgICAgICAgICAgICBzZWxmLmxvYWRfcGFn
ZV9tb2R1bGUoY3R4LCBwYWdlKQogICAgICAgICBleGNlcHQgQXBwbGljYXRpb25FcnJvciwgZToK
LSAgICAgICAgICAgIGlmIG5vdCBzdHIoZSkuc3RhcnRzd2l0aCgnTm8gbW9kdWxlIG5hbWVkICVz
JyAlIHBhZ2Uuc3BsaXQoJy8nKVstMV0pOgorICAgICAgICAgICAgaWYgbm90IHN0cihlKS5zdGFy
dHN3aXRoKCdObyBtb2R1bGUgbmFtZWQnKQogICAgICAgICAgICAgICAgIHJhaXNlCiAgICAgICAg
ICAgICBjdHgubG9jYWxzLnBhZ2VfbmFtZSA9IHBhZ2UKICAgICAgICAgICAgIHNlbGYuX19wYWdl
X2ZvdW5kID0gMAo=
--0016e6db2999edb2e50486925792
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Albatross-users mailing list
[email protected]
https://www.object-craft.com.au/cgi-bin/mailman/listinfo/albatross-users

--0016e6db2999edb2e50486925792--