Re: small bugfixes

hi claudio, 

Claudio Piciarelli <[email protected]> wrote:
> Hello cthumb developers,
> I've found two small bugs in the current cvs version of cthumb
> (cthumb.in 1.22):
> 
> * Creating an album using the default album file (generated by cthumb -c)
> gives a cp warning, since we try to copy the theme over itself:
> 
> $ cthumb ljubljanskata.album
> cthumb 4.3.1, running in /var/home/piccia/tmp/c
> cp: /usr/local/share/images/cthumb/neat-round.theme' and
> /usr/local/share/images/cthumb/neat-round.theme' are the same file 

i think this can be solved by uring rsync -avq as the copying
method. what do you have as "RecursiveCP" ?
i assume it is cp -a or cp -r?

please try your proposed patch with rsync -avq (teh default)
to make sure your proposed changes do not break anything.

if it works, please check it in.

> * Due to an incorrect regular expression, the trailing spaces in the
> config values are not stripped.

i am not sure about the context. can you put an example?

in any case, please check in your changes after some testing
you think it is appropriate. i added your sf account to the
project, so you should be able to check stuff in.

here is what i do to check stuff in. i do

	cvs diff -u > my.diff

of the project (the root directory).

then i include my.diff as the cvs log, because that way it gets
included in the email that is sent out and everyone in the
project sees the changes. how does that sound?

thanks,

-c


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/