[curl/curl] 9c7bc4: cookies: refactor comments

Daniel Gustafsson <[email protected]> Sun, 09 May 2021 13:40:12 -0700
Newsgroups gmane.comp.web.curl.cvs
Message-ID <curl/curl/push/refs/heads/bagder/dh-cookie-bake/[email protected]>
  Branch: refs/heads/bagder/dh-cookie-bake
  Home:   https://github.com/curl/curl
  Commit: 9c7bc4ad0f29be3d2b11a517786a928cbbe90604
      https://github.com/curl/curl/commit/9c7bc4ad0f29be3d2b11a517786a928cbbe90604
  Author: Daniel Gustafsson <[email protected]>
  Date:   2021-05-09 (Sun, 09 May 2021)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  cookies: refactor comments

Comments in the cookie code were a bit all over the place in terms of
style and wording. This takes a stab at cleaning them up by keeping to
a single style and overall shape. Some comments are moved a little and
some removed alltogether due to being redundant. No functional changes
have been made,


  Commit: 17c5d5567544a5e057fb44c33787e3141b93340d
      https://github.com/curl/curl/commit/17c5d5567544a5e057fb44c33787e3141b93340d
  Author: Daniel Gustafsson <[email protected]>
  Date:   2021-05-09 (Sun, 09 May 2021)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  cookies: make use of string duplication function

strstore() is defined as a strdup which ensures to free the target
pointer before duping the source char * into it. Make use of it in
two more cases where it can simplify the code.


  Commit: 4a578d58198f6ad84e5b5553520dce1f9d752eba
      https://github.com/curl/curl/commit/4a578d58198f6ad84e5b5553520dce1f9d752eba
  Author: Daniel Gustafsson <[email protected]>
  Date:   2021-05-09 (Sun, 09 May 2021)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  cookies: use CURLcode for cookie_output reporting

Writing the cookie file has multiple error conditions, and was using an
int with magic numbers to report the different error (which in turn were
disregarded anyways). This moves reporting to use a CURLcode value.


Compare: https://github.com/curl/curl/compare/9c7bc4ad0f29%5E...4a578d58198f
_______________________________________________
curl-commits mailing list
[email protected]
https://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits