[curl/curl] 54bd65: cookies: refactor comments

Daniel Gustafsson <[email protected]> Mon, 10 May 2021 23:49:57 -0700
Newsgroups gmane.comp.web.curl.cvs
Message-ID <curl/curl/push/refs/heads/master/[email protected]>
  Branch: refs/heads/master
  Home:   https://github.com/curl/curl
  Commit: 54bd65cabd6ac619fe4ea25e2746e0117f89f170
      https://github.com/curl/curl/commit/54bd65cabd6ac619fe4ea25e2746e0117f89f170
  Author: Daniel Gustafsson <[email protected]>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  cookies: refactor comments

Comments in the cookie code were a bit all over the place in terms of
style and wording. This takes a stab at cleaning them up by keeping to
a single style and overall shape. Some comments are moved a little and
some removed alltogether due to being redundant. No functional changes
have been made,


  Commit: 98888e6070a64e291914164cc1a0af5e3df2b0c2
      https://github.com/curl/curl/commit/98888e6070a64e291914164cc1a0af5e3df2b0c2
  Author: Daniel Gustafsson <[email protected]>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  cookies: make use of string duplication function

strstore() is defined as a strdup which ensures to free the target
pointer before duping the source char * into it. Make use of it in
two more cases where it can simplify the code.


  Commit: 24c71d62eee47bdd59973e6bf83a6282773b6e8e
      https://github.com/curl/curl/commit/24c71d62eee47bdd59973e6bf83a6282773b6e8e
  Author: Daniel Gustafsson <[email protected]>
  Date:   2021-05-11 (Tue, 11 May 2021)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  cookies: use CURLcode for cookie_output reporting

Writing the cookie file has multiple error conditions, and was using an
int with magic numbers to report the different error (which in turn were
disregarded anyways). This moves reporting to use a CURLcode value.

Lightly-touched-by: Daniel Stenberg

Closes #7037
Closes #6749


Compare: https://github.com/curl/curl/compare/455a63c66f18...24c71d62eee4
_______________________________________________
curl-commits mailing list
[email protected]
https://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits