Re: Segfault at <CTRL> s

On Sat, Jul 30, 2011 at 12:14:30AM +0200, Alexander Voigt wrote:
> Dear Dillo developers,
> 
> since some days I get a segfault when starting the web search via
> <CTRL>s (using the dillo 3.0 trunk).  Here is the backtrace:
> 
> 
> $ gdb ./dillo 
> GNU gdb (GDB) 7.0.1-debian
> Copyright (C) 2009 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "x86_64-linux-gnu".
> For bug reporting instructions, please see:
> <http://www.gnu.org/software/gdb/bugs/>...
> Reading symbols from /PATH/TO/DILLO/dillo...done.
> (gdb) r
> Starting program: /PATH/TO/DILLO/dillo
> [Thread debugging using libthread_db enabled]
> dillo_dns_init: Here we go! (threaded)
> Disabling cookies.
> Nav_open_url: new url='http://www.google.de'
> [New Thread 0x7ffff5111700 (LWP 21693)]
> Dns_server [0]: www.google.de is 74.125.43.106 74.125.43.104 74.125.43.99 74.125.43.147 74.125.43.105 74.125.43.103
> [Thread 0x7ffff5111700 (LWP 21693) exited]
> Connecting to 74.125.43.106
> 
> <snip>Now I press <CTRL> s</snip>
> 
> Program received signal SIGSEGV, Segmentation fault.
> __strrchr_sse2 () at ../sysdeps/x86_64/multiarch/../strrchr.S:33
> 33           ../sysdeps/x86_64/multiarch/../strrchr.S: Can't find file or directory.
>              in ../sysdeps/x86_64/multiarch/../strrchr.S
> Current language:  auto
> The current source language is "auto; currently asm".
> (gdb) l
> 28    in ../sysdeps/x86_64/multiarch/../strrchr.S
> (gdb) bt
> #0  __strrchr_sse2 () at ../sysdeps/x86_64/multiarch/../strrchr.S:33
> #1  0x0000000000410640 in a_Misc_parse_search_url (source=0x0, 
>     label=0x7fffffffdb58, urlstr=0x7fffffffdb50) at misc.c:395
> #2  0x0000000000414ddf in a_Dialog_input (msg=<value optimized out>)
>     at dialog.cc:167
> #3  0x000000000040d137 in a_UIcmd_search_dialog (vbw=0x774180) at uicmd.cc:820
> #4  0x000000000040a9fd in UI::handle (this=0x7951a0, event=12) at ui.cc:821
> #5  0x000000000046451b in send(int, Fl_Widget*, Fl_Window*) ()
> #6  0x0000000000465415 in Fl::handle_(int, Fl_Window*) ()
> #7  0x000000000046533c in Fl::handle_(int, Fl_Window*) ()
> #8  0x0000000000485530 in fl_handle(_XEvent const&) ()
> #9  0x000000000048558d in do_queued_events() ()
> #10 0x00000000004857ac in fl_wait(double) ()
> #11 0x0000000000465c23 in Fl::wait(double) ()
> #12 0x0000000000465c93 in Fl::run() ()
> #13 0x0000000000407f14 in main (argc=1, argv=0x7fffffffe3c8) at dillo.cc:429

  Does this fix it?

  dialog.cc:167

-          if (a_Misc_parse_search_url(source, &label, &url) < 0)
+          if (!source || a_Misc_parse_search_url(source, &label, &url) < 0)


-- 
  Cheers
  Jorge.-