Re: page that redraws endlessly
Jorge Arellano Cid <[email protected]>
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Sep 04, 2011 at 09:00:27PM +0200, Johannes Hofmann wrote:
> Thanks for the cleaned up test case. It's still remarkably complex.
> I see the issue also with dillo-2.1.1. Nevertheless we should
> definately try to fix it. I will play with it a bit...
After a short review, it looks non-trivial to me. It involves
white space handling, which has a design review pending, and also
there's this comment in textblock.cc:
/* NOTE: Most code relies on that all values of nowrap are equal for all
* words within one line. */
And effectively, the 'nowrap' value is taken from the first
word of the line:
ws = words->getRef(line->firstWord)->style->whiteSpace;
nowrap = ws == core::style::WHITE_SPACE_PRE ||
ws == core::style::WHITE_SPACE_NOWRAP;
Given this is a design issue from long ago (dillo-2.2.1 also
has it), and all the testing/debugging such a change requires,
I'm for leaving this task for the next release.
--
Cheers
Jorge.-