Fwd: Bug#642391: dillo: sane default for http redirects [origin: [email protected]]

Hi,

this bug report came in for dillo 3.0 in Debian Unstable/Testing, see
also http://bugs.debian.org/642391

See below for my thoughts.

----- Forwarded message from The Don Lachlan <[email protected]> -----
From: The Don Lachlan <[email protected]>
Date: Thu, 22 Sep 2011 02:07:15 -0400
Subject: Bug#642391: dillo: sane default for http redirects
To: Debian Bug Tracking System <[email protected]>
User-Agent: Mutt/1.5.21 (2010-09-15)

Package: dillo
Version: 3.0-1
Severity: important

Dear Maintainer,

By default, Dillo 3.0 does not follow HTTP redirects between second level
domains (foo.com -> bar.com), which breaks URL shorteners and many web
sites. This is controlled by the configuration option "filter_auto_requests"
and defaults to "same_domain".

I've attached two patches. The first modifies the source to "allow_all" by
default and the commented entry in the rc file; the second modifies the rc
file to "allow_all" by default. The first patch is preferable so that

1) the source code defaults match the shipped rc file

2) users who have an existing ~/.dillo/dillorc (and ignore the global
   dillorc) will receive the proper default of "allow_all" if they lack a
   "filter_auto_requests" entry 

-Lachlan (this is a resend, it left my MTA but never reached the bug logs)

-- System Information:
[...]

--- dillo-3.0/dillorc	2011-09-21 15:38:16.664618360 -0400
+++ dillo-3.0/dillorc	2011-09-21 18:21:26.000000000 -0400
@@ -31,7 +31,7 @@
 # allow_all
 # same_domain : Permit www.example.org to load an image from img.example.org,
 #               but not from the unrelated ad.doubleclick.net.
-#filter_auto_requests=same_domain
+#filter_auto_requests=allow_all
 
 # Change the buffering scheme for drawing
 # 0 no double buffering - useful for debugging
--- dillo-3.0/src/prefs.c	2011-09-21 18:52:17.000000000 -0400
+++ dillo-3.0/src/prefs.c	2011-09-21 18:52:54.000000000 -0400
@@ -40,7 +40,7 @@
    prefs.buffered_drawing = 1;
    prefs.contrast_visited_color = TRUE;
    prefs.enterpress_forces_submit = FALSE;
-   prefs.filter_auto_requests = PREFS_FILTER_SAME_DOMAIN;
+   prefs.filter_auto_requests = PREFS_FILTER_ALLOW_ALL;
    prefs.focus_new_tab = TRUE;
    prefs.font_cursive = dStrdup(PREFS_FONT_CURSIVE);
    prefs.font_factor = 1.0;

--- dillo/dillorc	2011-09-21 15:38:16.664618360 -0400
+++ dillo/dillorc	2011-09-21 15:38:42.000000000 -0400
@@ -31,7 +31,7 @@
 # allow_all
 # same_domain : Permit www.example.org to load an image from img.example.org,
 #               but not from the unrelated ad.doubleclick.net.
-#filter_auto_requests=same_domain
+filter_auto_requests=allow_all
 
 # Change the buffering scheme for drawing
 # 0 no double buffering - useful for debugging
----- End forwarded message -----

Until now I noticed the effects of filter_auto_requests just for
images and was quite happy with it. But with images you can click on
them and they will be loaded. This does not seem to work for
cross-domain redirects. And as annoying as URL shorteners are, I
usually do like to follow those redirects.

Is it possible to separate the settings for images and redirects? Or
is it possible to allow those redirect on a case-by-case base?

One easy way to do so would to display the content of the redirect
page which usually contains a link to the redirect target.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | [email protected]  (Mail)
 X   See http://www.asciiribbon.org/              | [email protected] (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)