Re: ascii string comparison [Re: use C locale for LC_CTYPE]

Jorge wrote:
> On Mon, Nov 07, 2011 at 10:25:39PM +0100, Johannes Hofmann wrote:
> > On Sun, Nov 06, 2011 at 08:19:07PM +0000, corvid wrote:
> > > Johannes wrote:
> > > > I'd just go with the approach in your first patch.
> > > 
> > > All right then. Do you have any thoughts on what function names
> > > would be least unwieldy / most descriptive / best fitting in
> > > with their surroundings?
> > > 
> > > I'm thinking maybe dAsciiToupper() and dStrAsciiCasecmp().
> > 
> > Let's see what others do:
> > 
> > * KDE:      kAsciiToUpper() [1]
> > * glib:     g_ascii_toupper() [2]
> > * ffmpeg:   av_toupper() [3]
> > * libevent: evutil_ascii_strcasecmp() [4]
> > 
> > So dAsciiToupper() and dStrAsciiCasecmp() look good to me.
> 
>   +1

I think I'll go with D_ASCII_TOUPPER because the argument gets
evaluated more than once, and we don't want nasty surprises.


(I'm tempted to say "Or ASCII_TOUPPER?", but it'd be nice for the
whole topic to come to an end, wouldn't it? :)