Re: [exprimental patch] wakeup instead of polling for dns

Jorge Arellano Cid <[email protected]>
Newsgroups gmane.comp.web.dillo.devel
Message-ID <[email protected]>
Hi Johannes,

On Mon, Feb 06, 2012 at 09:45:44PM +0100, Johannes Hofmann wrote:
> Hi,
> 
> attached experimental patch replaces the polling for DNS answers
> with the wakeup mechanism fltk provides.
> What do you think?

  Well dns resolving is delicate, but not sacred ;)

  AFAIS  the main advantage would be a near 0.1 second speedup on
average  when  displaying  non dns-cached pages, (0.2 best case).
Which is significative.

  Please let me know if there's another advantage I miss.

  The  cost  is using an FLTK mechanism (awake) which we don't in
the rest of the code.

  It looks clean. It should be tested on different platforms/OS.

  BTW,  dns.c has code for a blocking server (not threaded). Does
this  awake() call work OK when called from the same main thread?
Is  this by design or by chance? Maybe it would be safer to avoid
calling awake() in this case.


-- 
  Cheers
  Jorge.-
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.