Re: cleanup patches
Johannes Hofmann <[email protected]>
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, May 26, 2012 at 09:26:39AM -0400, Jorge Arellano Cid wrote: > On Sat, May 26, 2012 at 02:02:17PM +0200, Johannes Hofmann wrote: > > On Sat, May 26, 2012 at 03:02:24PM +0400, 123 wrote: > > > One patch for README, one for dFree (no need to check for NULL) and > > > one for sizeof usage. > > > > thanks, committed. > > BTW, why is it better to have sizeof this way? > > - (sizeof(Css_shorthand_info) / sizeof(CssShorthandInfo)) > + (sizeof(Css_shorthand_info) / sizeof(Css_shorthand_info[0])) This way it stays correct even if someone changes the type of Css_shorthand_info to say CssShorthandInfo2. Not a big improvement, but I like it being consistently done like that. Cheers, Johannes