Re: [patch] dlib cleanup

Jorge Arellano Cid <[email protected]>
Newsgroups gmane.comp.web.dillo.devel
Message-ID <[email protected]>
Hi,

On Sun, Jun 03, 2012 at 12:13:41AM +0400, 123 wrote:
> malloc.diff: added perror calls for malloc and realloc errors
> 
> dstr.diff: dStr* functions cleanup
> 
> dlist.diff: replaced recursive QuickSort with qsort from stdlib.h.
> Tested with file.dpi where it is used for sorting directory listing.

  There're different criteria to write code. In dlib, a few lines
are preferred to a single contracted one to make it simpler to
understand. In the same spirit, scattered return statements are avoided
to make code path following simpler.

  For quick sort I remember having to implement it in dlib because
stdlib's qsort varies among platforms.


-- 
  Cheers
  Jorge.-
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.