Re: hyphenation in dillo

On Thu, Sep 06, 2012 at 08:46:04PM +0200, Johannes Hofmann wrote:
> On Thu, Sep 06, 2012 at 07:51:08PM +0200, Johannes Hofmann wrote:
> > On Thu, Sep 06, 2012 at 10:22:15AM +0200, Sebastian Geerken wrote:
> > > On Wed, Sep 05, Johannes Hofmann wrote:
> > > > On Tue, Sep 04, 2012 at 02:36:29PM +0200, Sebastian Geerken wrote:
> > > > > > I'm mostly finished with cleaning up the calculation of extremes (used
> > > > > > for tables). This should already work now, please test it again.
> > > > > 
> > > > > Just pushed some more changes; should be complete now. Please test
> > > > > thoroughly.
> > > > > 
> > > > 
> > > > For me it crashes on e.g. focus.de after resizing the window or
> > > > clicking a link. The stack is pretty long: ...
> > > 
> > > Still? I found test/anchrors.html as a test case (crashing when the
> > > window is resized), but this is now fix. Please test again.
> > 
> > Works fine now! Very nice.
> 
> I found another example, where it still crashes:
> http://www.x.org/archive/X11R7.5/doc/man/man3/Xft.3.html
> 
> It crashes here if I make the window smaller.

Update: The following patch fixes the crash for me:

diff -r 8671009fbcaf dw/textblock_linebreaking.cc
--- a/dw/textblock_linebreaking.cc	Thu Sep 06 18:09:03 2012 +0200
+++ b/dw/textblock_linebreaking.cc	Sun Sep 09 22:31:01 2012 +0200
@@ -588,6 +588,9 @@
                   wordIndexEnd += n;
                PRINTF ("[%p] -> new searchUntil = %d ...\n", this, searchUntil);
                lineAdded = false;
+               // update word pointer as hyphenateWord() can trigger a
+               // reorganization of the words structure
+               word = words->getRef (wordIndex);
             }
             
             PRINTF ("[%p]       accumulating again from %d to %d\n",