Re: Changes in hyphenation

On Fri, Nov 02, Sebastian Geerken wrote:
> On Mon, Oct 29, Johannes Hofmann wrote:
> > On Mon, Oct 29, 2012 at 08:08:16PM +0100, Sebastian Geerken wrote:
> > > I just pulled some change to make <pre> work. Please test it again,
> > > even things which have worked recently, so that we can be sure that
> > > nothing is broken again.
> > 
> > Works very nice for me! With the following change:
> > 
> > diff -r 5e7a06855f37 dw/textblock.hh
> > --- a/dw/textblock.hhMon Oct 29 20:05:20 2012 +0100
> > +++ b/dw/textblock.hhMon Oct 29 22:23:15 2012 +0100
> > @@ -552,8 +552,7 @@
> >     {
> >        if (style->whiteSpace != core::style::WHITE_SPACE_NOWRAP &&
> >            style->whiteSpace != core::style::WHITE_SPACE_PRE)
> > -         if (word->badnessAndPenalty.lineMustBeBroken())
> > -            word->badnessAndPenalty.setPenalty (0);
> > +         word->badnessAndPenalty.setPenalty (0);
> >     }
> >  
> >     void addHyphen();
> > 
> > ideographic characters also seem to work again, but I'm not sure
> > about all the side-effects.
> 
> Er ... this patch modifies Textblock::addBreakOption(), which is not
> used anymore (neither of the two variants), so how can this change
> anything?

Sorry, I see it now.

Johannes patch is (with some changes) applied. Furaisanjin: are there
still issues?

Sebastian