Re: [patch] Gopher DPI
Jorge Arellano Cid <[email protected]>
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Dec 16, 2012 at 12:31:19AM +0400, [email protected] wrote: > Now search works properly. URL looks like > gopher://gopher.floodgap.com:70/7/v2/vs?query=dillo, but ?query is > replaced with %09 internally. I have not found the way to make > redirect. The patch is ready to be commited and should not break > anything as it is a separate DPI that is only called for gopher URLs. > > I will try to implement search without forms by adding input dialogs > as a separate patch in my patch queue on top of it. User experience > will be similar to lynx: you open the page and then browser asks you > for search query. Are you sure a dialog is better than a simple form (as with bookmarks)? I'll review the patch as soon as I find the necessary time. So far from what I've read in the list, it looks OK. Just some friendly advice: don't rush; you'll find plenty of options along the way, and independent as a dpi is, it looks much like it will make it into the next release. > Also patch for src/IO/dpi.c is attached to make Dpi_parse_token more > robust as I accedently made it segfault during development of gopher > DPI. Yes, there're subtle interactions and assumptions in dpip. That's why I'd like to take the necessary time to review the FD leak patch and then the gopher dpi. -- Cheers Jorge.-