Re: Patch for xembed (updated for resize)

Hi,
well the aim would be to contribute to dillo to make it embeddable by 
X11 applications.

If you want to achieve this with "standard" XEMBED protocol only, I am 
off -that's not my domain...

I have tested/debugged the current code with 'tabbed' (as you suggested) 
and found out, that it works even better if the ClientMessage code (and 
this is the only relevant code here) is removed.

tabbed also showed some glitches with the current code:

- dillo's File menu opens at different positions after moving
- clicking in the grey space right to dillo's 'Tools' icon seems to 
crash something...

So I removed the whole thing.

Did you try my patch?

It certainly works not only from FLTK applications.
You can verify that, if you try to embed dillo into any window on your 
desktop e.g. a gnome terminal (use xwininfo to find out its xid).

I do not claim that my patch is complete already, but it may at least be 
used as a starting point. At least it has the advantage, that the 
embedder does not need to do anything, except passing an xid.

If keeping the old code is your only concern, then I can re-integrate it 
into my patch again - it has no effect on it at all.

Cheers
chris


> Hi,
>
> On Sat, Dec 15, 2012 at 12:04:35PM +0100, podarcis wrote:
>> Hi,
>>
>> here is an updated version making resize work.
>> It still works with tabbed too.
>> Note that I have had no knowledge of X or xembed at all, so all
>> changes come from experimenting...
>> I removed large parts of the existing code, because they did nothing
>> in my environment.
>>
>> Please have a look at it.
>
> hm, the patch basically removes support for the xembed protocol. Is
> it meant as a diagnostic patch to investigate a problem, or meant
> for inclusion into the dillo repository?
> It won't work for the latter case. You can't just remove code that
> is not needed for your specific case.
> If you just want to get embedding of dillo into an fltk based window
> working, you would need to send the proper xembed X11 event from your
> embedding fltk program. Look at what tabbed is doing.
> I can also dig into my old stuff, I think I once had a minimal fltk
> based embedder working.
>
> Cheers,
> Johannes
>
> _______________________________________________
> Dillo-dev mailing list
> [email protected]
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>