Re: Patch for xembed updated

Hi,

On Sat, Jan 05, 2013 at 10:56:00AM +0100, podarcis wrote:
> Hi,
> 
> I have updated my patch (no removal of existing code, added
> comments, trimmed the source,..).
> 
> Let me perhaps explain from the beginning:
> 
> My starting point was, that when embedding dillo from an external
> program using the --xid parameter, dillo's window didn't show up in
> the embedder.

Thanks for the updated patches and the background info. Here is some
background info on the xembed stuff from my side:

dillo2 supported xembed more or less automatically as it was based
on gtk2. The claws-mail dillo plugin used this feature to display html.

When porting dillo to fltk we had to implement xembed on our own or
break support for the claws-mail plugin.
That's why we added xembed.cc.

> 
> I have now found, there's a one-line fix for that problem:
> 
> -> dillo_xembed_patch_1.txt

I tend to commit this, but I still need to double check that it
doesn't cause any problems.
The advantage is that it will give some initial encouraging result
if someone tries out --xid without a fullblown xembed implementation.

> 
> After that was working again (by the way: it worked in dillo2
> already) I tried to make resizing of the embedder window work too:
> 
> -> dillo_xembed_patch_2.txt
> 
> A test program for all this:
> 
> -> dembed.cxx

I would prefer a minimal fltk-based example program in the test
directory, that implements the embedder side of xembed.
It shouldn't be too hard to do (e.g. by looking at the tabbed
sources).
It would be cool if you would like to work on that.
BTW. we use a pretty restricted set of C++ features in the dillo
source tree (e.g. we don't use iostream).

Cheers,
Johannes