Re: [patch] a_Dpip_send_cmd

Jorge Arellano Cid <[email protected]> Mon, 14 Jan 2013 10:52:03 -0300

Newsgroups	gmane.comp.web.dillo.devel
Message-ID	<[email protected]>

Hi,

On Sun, Jan 13, 2013 at 01:41:37AM +0400, [email protected] wrote:
> http://www.inventati.org/noname/dillo/dpip-send-cmd.patch
> 
> Patch adds a_Dpip_send_cmd and helper function a_Dpip_vbuild_cmd.
> 
> This way common pattern
> 
>   d_cmd = a_Dpip_build_cmd(format, ...);
>   st = a_Dpip_dsh_write_str(sh, flush, d_cmd);
>   dFree(d_cmd);
> 
> can be replaced with
> 
>   st = a_Dpip_send_cmd(sh, flush, format, ...);

  The  idea  looks good, and after applying it, the patch doesn't
compile; the problem is trivial but it makes me hesitate.

  Please at least check the patch compiles, and that the functionality
it changes/modifies works for every case, before submitting.

  TIA.

-- 
  Cheers
  Jorge.-