Re: [patch] Scrollbar thickness from dillorc

On Sun, Jan 20, 2013 at 04:01:11PM +0100, podarcis wrote:
> Scrollbars currently have the hardcoded thickness 15. This can be too
> small to operate dillo on large screens or with fingers on a touch
> screen.
> 
> The supplied patch does the following: 
> 
> - Adds the prefence "scrollbar_tickness" to dillorc.
> 
> - Reads the value into the prefences
>   (Note: added a type UINT32 to prefsparse.cc)
> 
> - Sets this value to the FltkViewport with the new
>   method FltkViewport::setScrollbarThickness().
> 
> Note: I deliberately did no check for value 0, which can therefore be
> used to make the scrollbars invisible. Scrolling can then still be
> achieved with the cursor keys. This could be called a feature.

I like the idea and want to commit this if no one objects.
Some issues I see with the current patch:

* I would rather drop PREFS_UINT32 and simply use
  PREFS_INT32 instead. But if we want to keep it, it should warn if
  a negative value is assigned to a PREFS_UINT32 variable.
* Similarily in dw/* I would use int instead of size_t. We also use
  int for width and height as does fltk.
* In C++ code we use camel cased variables and paramters, so it
  should be scrollbarThickness in dw/*.
* I'd make the scrollbarThickness member in FltkViewport non-static
  and it should be private.

I especially like that one can set scrollbar_thickness to 0 in
dillorc.

Cheers,
Johannes