Re: what's currently broken in dillo

On Tue, Nov 25, 2014 at 08:14:45PM +0000, eocene wrote:
> I wrote:
> > Jorge wrote:
> > > On Wed, Nov 19, 2014 at 08:16:20PM +0000, eocene wrote:
> > > > Jorge wrote:
> > > > >   I'd pack a 3.0.4.1 with the fix for FLTK-1.3.3.
> > > > 
> > > > Looking at ChangeLog, I'd argue that if we're making any release, we
> > > > should also have
> > > > 
> > > > - Don't load background images in --local mode.
> > > > 
> > > > and probably
> > > > 
> > > > - Fix Makefile to pick up LIBJPEG_CPPFLAGS.
> > > > 
> > > > and perhaps
> > > > 
> > > > - Remove Fl_Printer stub that always gave problems compiling under OSX.
> > > 
> > >  +1
> > 
> > It looks like I'll be semi-busy through Monday or so, but if no one
> > else feels like doing it, I'll look into creating a branch, committing
> > changes, version number, splash verbiage, etc....
> 
> After doing all of that just now, I was giving a little methodical testing
> before pushing my changes, and I found that there's still a bug in the focus
> fix.
> 
> If the page has focus, and the cursor leaves the page and returns to it, it
> seems to be fine.
> If an input has focus, and the cursor leaves the page and returns to it, it
> seems to be fine.
> If an input has focus and you click on the page to give it focus instead,
> and then the cursor leaves the page and returns to it, the input is given
> focus instead.

  Right!

  Please try this patch:

diff -r fb02b8b26017 dw/fltkviewbase.cc
--- a/dw/fltkviewbase.cc        Fri Nov 21 21:58:27 2014 +0100
+++ b/dw/fltkviewbase.cc        Thu Nov 27 10:10:22 2014 -0300
@@ -365,6 +365,8 @@ int FltkViewBase::handle (int event)
       // FLTK delivers UNFOCUS to the previously focused widget
       if (find(Fl::focus()) < children())
          focused_child = Fl::focus(); // remember the focused child!
+      else if (Fl::focus() == this)
+         focused_child = NULL; // no focused child this time
       return 0;
    case FL_KEYBOARD:
       if (Fl::event_key() == FL_Tab)


-- 
  Cheers
  Jorge.-