Re: here's 3.0.4.1 RC1

On Sun, Dec 07, 2014 at 12:15:02PM +0100, v4hn wrote:
> On Sun, Dec 07, 2014 at 11:55:43AM +0100, Johannes Hofmann wrote:
> > On Sat, Dec 06, 2014 at 01:22:06PM +0100, v4hn wrote:
> > > For me it's:
> > > 
> > > > $ xprop
> > > > WM_STATE(WM_STATE):
> > > >                 window state: Normal
> > > >                 icon window: 0x0
> > > > _NET_WM_ICON(CARDINAL) =
> > > > WM_HINTS(WM_HINTS):
> > > >                 Client accepts input or input focus: True
> > > > XdndAware(ATOM) = ATOM
> > > > WM_CLASS(STRING) = "dillo", "Dillo"
> > > > _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x0, 0x1, 0x1, 0x0, 0x0
> > > > WM_NORMAL_HINTS(WM_SIZE_HINTS):
> > > >                 program specified minimum size: 100 by 101
> > > >                 window gravity: Static
> > > > WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW
> > > > WM_ICON_NAME(STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > > _NET_WM_ICON_NAME(UTF8_STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > > WM_NAME(STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > > _NET_WM_NAME(UTF8_STRING) = "Dillo: Splash screen for dillo-3.0.4.1"
> > > 
> > > So yes, I see more realistic/useful size hints over here.
> > 
> > very odd. Are you 100% sure your dillo version is linked with
> > fltk-1.3.3 and not fltk-1.3.2? Do you maybe still have fltk-1.3.2
> > headers or libs somewhere on your system?
> 
> I'm 100% sure I have only fltk 1.3.3 around. Also if I try to build dillo-3.0.4
> on this machine I get the oldfocus symbol error which is fixed in 3.0.4.1.
> 
> > Are you using a prebuilt fltk-1.3.3 or did you compile from source?
> 
> I'm running Lunar-Linux which builds everything from source.
> The build instructions for fltk can be found here:
> https://github.com/lunar-linux/moonbase-other/tree/master/libs/fltk
> 
> Dillo's instructions are available here:
> https://github.com/lunar-linux/moonbase-other/tree/master/web/dillo
> The only thing I changed in there is the version number and checksum.

Ok, thanks. Interestingly if I comment out the following code that was
introduced in fltk-1.3.3 things work as expected for me:

--- src/Fl.cxx.orig     2014-12-07 12:27:31.291453000 +0100
+++ src/Fl.cxx  2014-12-07 12:44:14.991338000 +0100
@@ -962,6 +962,7 @@
          if (x) x->set_key_window();
        }
 #elif defined(USE_X11)
+       /*
        if (fl_xfocus != win) {
          Fl_X *x = Fl_X::i(win);
          if (!Fl_X::ewmh_supported())
@@ -969,6 +970,8 @@
          else if (x) // New WMs use the NETWM attribute:
            Fl_X::activate_window(x->xid);
        }
+       */
+       fprintf(stderr, "====> Fl_X::ewmh_supported() -> %d\n", Fl_X::ewmh_supported());
 #endif
        fl_xfocus = win;
       }


The fprintf line gives:
====> Fl_X::ewmh_supported() -> 0
on my system. 
Could you try the above patch to fltk-1.3.3 on you system too and report
what Fl_X::ewmh_supported() returns on your system?

Cheers,
Johannes