Re: here's 3.0.4.1 RC1

On Mon, Dec 08, 2014, v4hn wrote:
> On Mon, Dec 08, 2014 at 01:11:38AM +0100, Sebastian Geerken wrote:
> > On Mon, Dec 08, 2014, v4hn wrote:
> > > Talking about bugs... I just found out this version segfaults over here
> > > if I enter any string containing a space character. For example entering
> > > "foo bar" into the adress line and hitting enter segfaults over here.
> > > Can anyone reproduce this?
> > 
> > Yes, if and only if "search_url" is not defined. (I'm happy with DDG.)
> > This bug occurs already in release 3.0.4.
> 
> Yes, setting search_url makes the bug disappear. Thanks for investigating!

It seems that this change fixes it:

----------------------------------------------------------------------
diff -r 9aa37b81c609 src/prefs.c
--- a/src/prefs.c       Tue Dec 02 16:33:49 2014 +0100
+++ b/src/prefs.c       Mon Dec 08 12:37:15 2014 +0100
@@ -18,7 +18,7 @@
 #define PREFS_FONT_CURSIVE    "URW Chancery L"
 #define PREFS_FONT_FANTASY    "DejaVu Sans" /* TODO: find good default */
 #define PREFS_FONT_MONOSPACE  "DejaVu Sans Mono"
-#define PREFS_SEARCH_URL      "http://duckduckgo.com/lite/?kp=-1&q=%s"
+#define PREFS_SEARCH_URL      "dd http://duckduckgo.com/lite/?kp=-1&q=%s"
 #define PREFS_NO_PROXY        "localhost 127.0.0.1"
 #define PREFS_SAVE_DIR        "/tmp/"
 #define PREFS_HTTP_REFERER    "host"
@@ -82,7 +82,6 @@
    prefs.save_dir = dStrdup(PREFS_SAVE_DIR);
    prefs.search_urls = dList_new(16);
    dList_append(prefs.search_urls, dStrdup(PREFS_SEARCH_URL));
-   dList_append(prefs.search_urls, NULL); /* flags a default search URL */
    prefs.search_url_idx = 0;
    prefs.show_back = TRUE;
    prefs.show_bookmarks = TRUE;
----------------------------------------------------------------------

Not committed yet, since I'm not sure about the rationale.

Sebastian

_______________________________________________
Dillo-dev mailing list
[email protected]
http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBAgAGBQJUhY4/AAoJEAw7+YHB+ZL6ovMH/2Qys3pqSPSJ0Tq+NhXLdEs3
mkNkw19cfd9Pl06dHR00i/VEbHcUJfUo8TKhMbBifbIjQw6j5aSMtXGI5dGJK7+u
6mJ7PqEQVjNvVoUUi50LAYMOzw5uJG02kx4BuKQAz2d25EMj9X7YUcBK/DDQoCvE
+UpFoAOv2rHBFtpAFLFjqyELH/gC79ZvWB6Re9+KowIHIwtgYKtHvIN+QMTFqukp
f7QP0OFHJEE5+yBSSip2UmQEr33DJ+8QVXIAAAMPQgLDzCMHfE2m/CoGGjDMNThk
TR9zS0YqzAk6hUqgaRLdhciK7oU4xW4MnL3qVxQTovl4d/8fBki3PH5XgMUSWJc=
=VF2h
-----END PGP SIGNATURE-----