Re: Dillo crash on HTTPS connection (to MS web site)

On Wed, Feb 24, 2016 at 11:41:48PM +0200, John Found wrote:
> Oh, sorry. I was happy to have it work and forgot to report. :)
> Here is the dump from the error, down to the end:
> 
> ** ERROR **: our TLS mystery error is: error:140C5042:SSL routines:ssl_undefined_function:called a function you should not call

Ah, openssl makes so little effort toward anything.
I see that apache, nginx, etc. started to see lots of those messages with
openssl 1.0.2f, so I tried that version, and still no error messages for me.
(1.0.2f apparently becomes somewhat strict about shutdown during handshake,
whereas it seems earlier versions would just report success and not do
anything.)

There is an ERR_get_error_line() function which might help. Diff attached.
The manpage didn't bother to go into any normal detail about the buffer it
wants for the filename argument, of course, but we'll see.

_______________________________________________
Dillo-dev mailing list
[email protected]
http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev

diff -r 50d1c1aff6ae src/IO/tls.c
--- a/src/IO/tls.c	Mon Jan 25 19:48:54 2016 +0100
+++ b/src/IO/tls.c	Thu Feb 25 05:05:33 2016 +0000
@@ -1166,6 +1166,8 @@
    SSL *ssl;
    bool_t success = TRUE;
    int connkey = -1;
+   int line;
+   const char *filename = dNew(char, 100);
 
    if (!ssl_context)
       success = FALSE;
@@ -1173,6 +1175,12 @@
    if (success && Tls_user_said_no(url)) {
       success = FALSE;
    }
+   { int long e = ERR_get_error_line(&filename, &line);
+     if (e)
+        MSG_ERR("our TLS mystery error is: %s\nAt %s:%d\n",
+                ERR_error_string(e, NULL), filename, line);
+   }
+   free((char *)filename);
 
    assert(!ERR_get_error());