Re: Dillo crash on HTTPS connection (to MS web site)

Hi,

I was experiencing this assertion also now on
https://blog.scaleway.com/2016/03/08/c2-insanely-affordable-x64-servers/
and the patch below fixes it.

Cheers,
Johannes

On Wed, Mar 02, 2016 at 11:10:13AM +0000, eocene wrote:
> On Wed, Feb 24, 2016 at 11:41:48PM +0200, John Found wrote:
> > ** ERROR **: our TLS mystery error is: error:140C5042:SSL routines:ssl_undefined_function:called a function you should not call
> 
> If this is indeed the same problem that apache, nginx, et al., are seeing,
> then the attached should suffice to fix it.
> 

> diff -r 50d1c1aff6ae src/IO/tls.c
> --- a/src/IO/tls.c	Mon Jan 25 19:48:54 2016 +0100
> +++ b/src/IO/tls.c	Wed Mar 02 11:00:50 2016 +0000
> @@ -1041,7 +1041,12 @@
>           a_IOwatch_remove_fd(c->fd, -1);
>           dClose(c->fd);
>        }
> -      SSL_shutdown(c->ssl);
> +      if (!SSL_in_init(c->ssl)) {
> +         /* openssl 1.0.2f does not like shutdown being called during handshake,
> +          * resulting in ssl_undefined_function in the error queue.
> +          */
> +         SSL_shutdown(c->ssl);
> +      }
>        SSL_free(c->ssl);
>  
>        a_Url_free(c->url);

> _______________________________________________
> Dillo-dev mailing list
> [email protected]
> http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev