Re: Dillo_grows merged

On Sun, Apr 24, 2016 at 10:02:13PM +0000, eocene wrote:
> On Sun, Apr 24, 2016 at 09:15:42PM +0200, Sebastian Geerken wrote:
> > On Tue, Apr 19, 2016, eocene wrote:
> > > 
> > > Here's a segfault backtrace that I just got:
> > > 
> > > #0  0x080ab83d in dw::Textblock::sizeRequestReference (this=0x955e260, 
> > >     index=-1224641713) at textblock.cc:423
> > > #1  0x080bcd63 in dw::oof::OOFAwareWidget::OOFAwareWidgetIterator::numParts (
> > >     this=0x9e446a8, sectionIndex=-1, numContentsInFlow=0)
> > >     at oofawarewidget_iterator.cc:84
> > 
> > I do not understand what has actually happens (look at the code). Did
> > you compile dillo with -O2 or -O0? Can you provide a test case how
> > this is reproduced?
> > 
> > Perhaps this is related to another prolem: valgrind prints some
> > warnings, which neither make sense to me.
> 
> As I recall, I was double-checking whether the textarea row attr default
> was still 2 in html5 (https://www.w3.org/TR/html51/sec-forms.html#the-textarea-element)
> searching for "rows ". But when I try this again, it doesn't crash.
> 
> FWIW, I compiled with -O0.
> 
> *tries valgrind*
> I do get a number of "Conditional jump or move depends on uninitialised value(s)" when the page loads.
> 
> Searching the page doesn't cause any more, though.

Searching backward causes segfaults with regularity.

If I run under valgrind, I get:

==9344== Conditional jump or move depends on uninitialised value(s)
==9344==    at 0x80A4493: dw::oof::OOFPositionedMgr::sizeAllocateStart(dw::oof::OOFAwareWidget*, dw::core::Allocation*) (oofpositionedmgr.cc:78)
==9344==    by 0x809F7E6: dw::oof::OOFAwareWidget::sizeAllocateStart(dw::core::Allocation*) (oofawarewidget.cc:347)
==9344==    by 0x80ABDB6: dw::Textblock::sizeAllocateImpl(dw::core::Allocation*) (textblock.cc:585)
==9344==    by 0x80E0DAD: dw::core::Widget::sizeAllocate(dw::core::Allocation*) (widget.cc:1135)
==9344==    by 0x80D3D77: dw::core::Layout::resizeIdle() (layout.cc:924)
==9344==    by 0x80C1B63: dw::fltk::FltkPlatform::generalIdle() (fltkplatform.cc:630)
==9344==    by 0x80C1AEB: dw::fltk::FltkPlatform::generalStaticIdle(void*) (fltkplatform.cc:620)
==9344==    by 0x4120CDB: ??? (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)
==9344==    by 0x4691E45: (below main) (libc-start.c:244)
==9344== 
==9344== Invalid read of size 4
==9344==    at 0x80BCFA7: dw::oof::OOFAwareWidget::OOFAwareWidgetIterator::getPart(int, int, dw::core::Content*) (oofawarewidget_iterator.cc:102)
==9344==    by 0x80BD27D: dw::oof::OOFAwareWidget::OOFAwareWidgetIterator::prev() (oofawarewidget_iterator.cc:204)
==9344==    by 0x80D0AA3: dw::core::DeepIterator::prev() (iterator.cc:708)
==9344==    by 0x80D0F91: dw::core::CharIterator::prev() (iterator.cc:825)
==9344==    by 0x80CEC72: dw::core::FindtextState::search(char const*, bool, bool) (findtext.cc:104)
==9344==    by 0x805AA00: dw::core::Layout::search(char const*, bool, int) (layout.hh:431)
==9344==    by 0x805A702: a_UIcmd_findtext_search (uicmd.cc:1484)
==9344==    by 0x8090AD6: Findbar::searchBackwards_cb(Fl_Widget*, void*) (findbar.cc:100)
==9344==    by 0x411F4FF: Fl_Widget::do_callback(Fl_Widget*, void*) (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)
==9344==    by 0x805306F: CustButton::handle(int) (tipwin.cc:194)
==9344==    by 0x40D99B3: ??? (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)
==9344==    by 0x40DA255: Fl_Group::handle(int) (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)
==9344==  Address 0x363 is not stack'd, malloc'd or (recently) free'd
==9344== 
==9344== 
==9344== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==9344==  Access not within mapped region at address 0x363
==9344==    at 0x80BCFA7: dw::oof::OOFAwareWidget::OOFAwareWidgetIterator::getPart(int, int, dw::core::Content*) (oofawarewidget_iterator.cc:102)
==9344==    by 0x80BD27D: dw::oof::OOFAwareWidget::OOFAwareWidgetIterator::prev() (oofawarewidget_iterator.cc:204)
==9344==    by 0x80D0AA3: dw::core::DeepIterator::prev() (iterator.cc:708)
==9344==    by 0x80D0F91: dw::core::CharIterator::prev() (iterator.cc:825)
==9344==    by 0x80CEC72: dw::core::FindtextState::search(char const*, bool, bool) (findtext.cc:104)
==9344==    by 0x805AA00: dw::core::Layout::search(char const*, bool, int) (layout.hh:431)
==9344==    by 0x805A702: a_UIcmd_findtext_search (uicmd.cc:1484)
==9344==    by 0x8090AD6: Findbar::searchBackwards_cb(Fl_Widget*, void*) (findbar.cc:100)
==9344==    by 0x411F4FF: Fl_Widget::do_callback(Fl_Widget*, void*) (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)
==9344==    by 0x805306F: CustButton::handle(int) (tipwin.cc:194)
==9344==    by 0x40D99B3: ??? (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)
==9344==    by 0x40DA255: Fl_Group::handle(int) (in /usr/lib/i386-linux-gnu/libfltk.so.1.3)