Re: Dillo_grows merged

On Mon, May 16, 2016 at 05:52:11PM +0200, Sebastian Geerken wrote:
> On So, Mai 15, 2016, Jorge Arellano Cid wrote:
> > Hi Sebastian,
> > 
> > On Sun, May 15, 2016 at 04:42:31PM -0400, Jorge Arellano Cid wrote:
> > > Hi there!
> > > 
> > > On Sun, May 15, 2016 at 01:17:40PM +0100, Nick Warne wrote:
> > > > On Sat, 14 May 2016 22:48:12 +0000
> > > > eocene <[email protected]> wrote:
> > > > 
> > > > > > Searching the page doesn't cause any more, though.  
> > > > > 
> > > > > Searching backward causes segfaults with regularity.
> > > > 
> > > > Messing about with this this morning, the segfault happens when using
> > > > 'previous' goes back past the first found 'next'.
> > > 
> > >   Yes.
> > > 
> > >   I sent this bug to Per Anderson a few weeks ago for him to debug,
> > > but didn't get an answer. @Per: did you get the email?
> > > 
> > >   Anyway, today I made a simple patch for it, but will investigate
> > > the issue a bit further before sending it to Sebastian for review.
> > 
> >   OK, the bisect shows the problem starts with commit 4241 which is
> > a new design for textblock iterators.
> > 
> >   The attached patch works OK for the text search, but I don't know
> > whether it fits with the overall design.
> > 
> >    It *seems to fit* but I'd prefer you to check it. ;)
> 
> I've just pushed a variant of your patch, please give it a try.

  Much better!

  I still wander what a negative sectionIndex means (0 is in flow).
It takes negative values sometimes. It should be commented.

  What should getPart() do upon a negative sectionIndex?

  HTH.

-- 
  Cheers
  Jorge.-