Re: Dillo_grows merged
"Sebastian Geerken" <[email protected]>
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
> > > The attached patch works OK for the text search, but I don't know > > > whether it fits with the overall design. > > > > > > It *seems to fit* but I'd prefer you to check it. ;) > > > > I've just pushed a variant of your patch, please give it a try. > > Much better! > > I still wander what a negative sectionIndex means (0 is in flow). > It takes negative values sometimes. It should be commented. It happens when iterating back gets behind 0. Likewise, it may become larger than NUM_SECTIONS - 1, when iterating forward. > What should getPart() do upon a negative sectionIndex? It should not be called, actually. This should be checked, first. Sebastian _______________________________________________ Dillo-dev mailing list [email protected] http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev
signature.asc
(application/pgp-signature, 473 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXPNp0AAoJEAw7+YHB+ZL696wH/20njltj0LxoLufOEypgCflB 6aVVTJFDK6tL0dwgUt5k5XbItv536/CtHaJHs8zeBnBLnH/DocGRXpokQdsnPKwV nYx1pezsCwftpFDMgwXqrJ68dhkUCPv75JphK1WTKZZlHHZLSR7jKuha+T/+vCUK U+yV6KCaJ7EYBT0w33THYM/TJLLTxp67+u6Is+MwBQ9aH/gwGqwTYnQ39vqV6VLR nbJw0avEA7e+/xypFCLNLuEv98Y10poKnwzpMmxBOal3tlxWOgFvutqIyla4sGrg CEzgPCDFbwwmYQ2gc1a/xEKNqI8jCxsI6Ot2QRtYrDwzGl0KDNKlddr6kEADU1E= =Ik3p -----END PGP SIGNATURE-----