cppcheck on Dillo source
Nick Warne <nick-ucsffw2X/[email protected]>
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi all, While waiting for the Tour De France to start on TV, I ran cppcheck on Dillo source for something to do - a few errors were picked up! I have compacted the findings (with two comments from me)and attached it as a plain text file. Keep up the great work guys and thanks! Nick -- Gosh that takes me back... or is it forward? That's the trouble with time travel, you never can tell." -- Doctor Who "Androids of Tara" _______________________________________________ Dillo-dev mailing list [email protected] http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev
cppcheck_dillo.txt
(text/plain, 1.8 KB)
Checking ../../slackbuilds/dillo/hg/dillo/dpi/file.c...
[../../slackbuilds/dillo/hg/dillo/dpi/file.c:356]: (error) syntax error
if S_ISDIR (finfo->mode) {
Nick-> maybe?:
if (S_ISDIR (finfo->mode)) {
Checking ../../slackbuilds/dillo/hg/dillo/dpid/dpid.c...
[../../slackbuilds/dillo/hg/dillo/dpid/dpid.c:465]: (error) Resource leak: dpidrc_stream
return -1;
Nick-> maybe?:
return (-1);
Checking ../../slackbuilds/dillo/hg/dillo/dw/hyphenator.cc...
[../../slackbuilds/dillo/hg/dillo/dw/hyphenator.cc:570]: (warning) %u in format
string (no. 1) requires 'unsigned int *' but the argument type is 'int *'.
Checking ../../slackbuilds/dillo/hg/dillo/dw/hyphenator.cc...
[../../slackbuilds/dillo/hg/dillo/dw/hyphenator.cc:570]: (warning) %u in format
string (no. 2) requires 'unsigned int *' but the argument type is 'int *'.
Checking ../../slackbuilds/dillo/hg/dillo/dw/iterator.cc...
[../../slackbuilds/dillo/hg/dillo/dw/iterator.cc:124]: (error) Memory leak: eit3
Checking ../../slackbuilds/dillo/hg/dillo/dw/ooffloatsmgr.cc...
[../../slackbuilds/dillo/hg/dillo/dw/ooffloatsmgr.cc:654]: (error) Possible null pointer dereference: vloat
Checking ../../slackbuilds/dillo/hg/dillo/lout/container.cc...
[../../slackbuilds/dillo/hg/dillo/lout/container.cc:143]: (error) Common realloc mistake: 'array' nulled but not freed upon failure
[../../slackbuilds/dillo/hg/dillo/lout/container.cc:177]: (error) Common realloc mistake: 'array' nulled but not freed upon failure
Checking ../../slackbuilds/dillo/hg/dillo/lout/misc.cc...
[../../slackbuilds/dillo/hg/dillo/lout/misc.cc:172]: (error) Common realloc mistake: 'bits' nulled but not freed upon failure
Truck loads of:
Checking ../../slackbuilds/dillo/hg/dillo/src/md5.c: ARCH_IS_BIG_ENDIAN...
[../../slackbuilds/dillo/hg/dillo/src/md5.c:216]: (error) Uninitialized variable: X
in md5.c