Re: Claws-mail dillo plugin

Lets clean that up:

--- src/plugins/dillo/dillo_viewer.c	2017-02-11
13:45:18.819635044 +0000 +++ ../dillo_viewer.c	2017-02-11
13:44:40.460558371 +0000 @@ -145,10 +145,11 @@
 		g_signal_connect(G_OBJECT(viewer->socket), "destroy", 
 				 G_CALLBACK(socket_destroy_cb),viewer);

-		cmd = g_strdup_printf("dillo %s%s-x %d \"%s\"",
+		/*cmd = g_strdup_printf("dillo %s%s-x %d \"%s\"",*/
+		cmd = g_strdup_printf("dillo %s%s\"%s\"",
 				      (!load_images(viewer) ? "-l " :""),
				      (dillo_prefs.full ? "-f " : ""),
-				      (gint)GDK_WINDOW_XWINDOW(viewer->socket->window),
+				      /*(gint)GDK_WINDOW_XWINDOW(viewer->socket->window),*/
				      viewer->filename);
 
 		execute_command_line(cmd, TRUE, NULL);


Nick

On Sat, 11 Feb 2017 13:51:42 +0000
Nick Warne <[email protected]> wrote:

> OK, I got this to work in dwm:
> 
> http://dwm.suckless.org
> 
> Basically, the dillo claws-plugin embeds dillo in a window panel - dwm
> doesn't like that at all, so after reading the code, changed this
> behaviour to allow dillo to open normally with the HTML mail - and it
> works pretty good.
> 
> The patch below shows the simple change:
> 
> 
> --- src/plugins/dillo/dillo_viewer.c
> 2017-02-11 13:45:18.819635044 +0000 +++ ../dillo_viewer.c
> 2017-02-11 13:44:40.460558371 +0000 @@ -145,10 +145,11 @@
>  		g_signal_connect(G_OBJECT(viewer->socket),
> "destroy", G_CALLBACK(socket_destroy_cb),
> viewer); 
> -		cmd = g_strdup_printf("dillo %s%s-x %d \"%s\"",
> +		/*cmd = g_strdup_printf("dillo %s%s-x %d \"%s\"",*/
> +		cmd = g_strdup_printf("dillo %s%s\"%s\"",
>  				      (!load_images(viewer) ? "-l " :
> ""), (dillo_prefs.full ? "-f " : ""),
> -				      (gint)
> GDK_WINDOW_XWINDOW(viewer->socket->window),
> +				      /*(gint)
> GDK_WINDOW_XWINDOW(viewer->socket->window),*/ viewer->filename);
>  
>  		execute_command_line(cmd, TRUE, NULL);
> 
> 
> Maybe this will help someone, somewhere...
> 
> Nick
> 
> 
> On Sat, 11 Feb 2017 12:33:40 +0000
> Nick Warne <[email protected]> wrote:
> 
> > I just done a git-pull on latest claws-mail, and there is now a new
> > plugin that uses dillo to read HTML mail if desired.
> > 
> > Works very well in xfce (but alas not in dwm for some reason that I
> > cannot work out).
> > 
> > Great work Jorge in helping them out!
> > 
> > Nick  
> 
> 
> 



-- 
Quidquid latine dictum sit, altum viditur.
(Whatever is said in Latin sounds profound.)

_______________________________________________
Dillo-dev mailing list
[email protected]
http://lists.dillo.org/cgi-bin/mailman/listinfo/dillo-dev