Re: Feature idea: zoom buttons

Hi,

On Thu, May 02, 2024 at 09:53:39AM -0400, Charles E. Lehner wrote:
>Sounds like a nice feature.
>and/or as menu items
>
>On Wednesday, 1 May 2024 18:02:39 EDT, [email protected] wrote:
>>Hello,
>>
>>Sometimes the page text is not entirely wrapped to the browser
>>window, resulting in lines extending off screen, which is a pain.

What do you mean by "resulting in lines extending off screen"? If you 
mean the Dillo viewport, that is probably caused by some missing CSS 
feature, which we should fix too, but shouldn't happen with CSS 
disabled.

>>This can be especially visible if remote CSS is disabled, and/or you
>>are using a portrait display. Maybe this can be partially mitigated by
>>having zoom buttons in the toolbar. Beyond that, there are many other
>>reasons why you might want to make the text larger or smaller,
>>depending on the page and display configuration, accessibility needs,
>>etc. It's not always practical to edit dillorc and restart for every
>>page in question.

I agree.

>>I think one of the Dillo forks did it before. Can we just dynamically
>>adjust the 'font_factor' setting? Any interest in this?

I think we should implement a zoom control, like on other browsers with 
Control + / Control -. Here is an issue on this topic:

https://github.com/dillo-browser/dillo/issues/21

I have a patch that implements it by adding a zoom factor that changes 
with Ctrl + and Ctrl -, but it doesn't work well in some cases. Notice 
that the font_factor is not the same as "zooming" all elements.

For example, if you load the old website and try to zoom with Ctrl +, 
the top image is not scaled accordingly:

$ dillo https://dillo-browser.github.io/old/index.html

Here is the branch[1] and patch[2]:

[1]:https://github.com/dillo-browser/dillo/compare/zoom-control
[2]:https://github.com/dillo-browser/dillo/commit/bfa6dfae82887ba51749cf4b713a75c9cfad136e.patch

I think it would made more sense to scale the complete page, and not 
only the font, but that would require a bit more work. We would need 
this anyway to implement proper DPI scaling.

Rodrigo.
_______________________________________________
Dillo-dev mailing list -- dillo-dev-lx9mn2B4QYRWk0Htik3J/[email protected]
To unsubscribe send an email to dillo-dev-leave-lx9mn2B4QYRWk0Htik3J/[email protected]