Re: extra /tmp on file name line when save html
| Newsgroups | gmane.comp.web.dillo.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
Thanks Rodrigo for working with Albrecht-S
i think this issue is now resolved for me
when saving an html
1. if i like the highlightd name given in the Filename: box i just click 'ok'
2. if i want to add more text or suffix to the highlighted name given in the Filename: box i just hit 'end' key (easier then using mouse click in filename box) and enter what i want
3, if i want to enter a completely new name to save in save_dir (problem being dillo enters /tmp now)
i don't know if changing rc = chdir("/tmp"); to rc = chdir("/html"); in src/paths.cc is what you meant by your suggestion :
> One option to work around it is to chdir() to the save_dir, so at least
> it would make a bit more sense.
but by doing so now
it now puts /html/'firstkeypressed' an i can put the name i want there
(i didn't know how to put the save_dir variable there instead of my hardcoded "/html" which would be better) (i get make error ->? save_dir not defined in this scope)
so all seems fixed - for me anyway
thank Albrecht-S for his work and interesting posts in the
https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570
i think the only issue left here is Albrecht-S saying that hitting '/' leaves a '/' there
my hitting the '/' key just erases highlight and leaves nothing in the filename box :)
On Sat, 6 Jul 2024 14:10:22 +0200
Rodrigo Arias <[email protected]> wrote:
> Hi,
>
> >the problem is 2 parts
> >in dillo - switching from the savedir to /tmp dir when first 'd'
> >pressed and then repeating /tmp/d/tmp/d when another 'd' is pressed
> >
> >the fix only fixes the repeat to /tmp/d/tmp/d when a second d is
> >pressed but the changing from savedir to /tmp/d still happens when
> >first d is pressed
> >
> >your program only shows the second part of the problem (and that part
> >is fixed) since it does the chdir("/tmp") itself and not what happens
> >with dillo when the first 'd' is pressed
> >
> >the fix only fixes the repeat not the initial change to /tmp dir from
> >the savedir
>
> This is a "design" decision by FLTK[1], as when a non-/ character is
> added it is considered as a relative path *to the current directory*
> which is always set to /tmp in Dillo (regardless of the save_dir) and it
> gets prefixed.
>
> [1]: https://github.com/fltk/fltk/issues/1004#issuecomment-2210810570
>
> One option to work around it is to chdir() to the save_dir, so at least
> it would make a bit more sense.
yes i edited src/paths.cc
rc = chdir("/html");
// rc = chdir("/tmp");
> Another good idea is to switch to the native file chooser which also
> comes with other niceties (but this problem will continue there if the
> native file chooser is not available).
what source is the 'native file chooser' in?
> Rodrigo.
> _______________________________________________
> Dillo-dev mailing list -- dillo-dev-lx9mn2B4QYRWk0Htik3J/[email protected]
> To unsubscribe send an email to dillo-dev-leave-lx9mn2B4QYRWk0Htik3J/[email protected]
_______________________________________________
Dillo-dev mailing list -- dillo-dev-lx9mn2B4QYRWk0Htik3J/[email protected]
To unsubscribe send an email to dillo-dev-leave-lx9mn2B4QYRWk0Htik3J/[email protected]