Re: install.php changes

On Sun, 2002-09-01 at 19:34, fireball-toeWGPj/1oVWk0Htik3J/[email protected] wrote:
> Quoting Scott Kindley <ckindley-/Nmu/[email protected]>:
> 
> > On Sun, 2002-09-01 at 15:59, fireball-toeWGPj/1oVWk0Htik3J/[email protected] wrote:
> > > Ok, I noticed something kind of weird and there's better and smaller
> > way to do 
> > > it. Here's my sugestion:
> > > 
> > > from 
> > > if(!isset($prefix)) {
> > > 	include_once 'config.php';
> > > 
> > > 	$prefix = $pnconfig['prefix'];
> > > 	$dbtype = $pnconfig['dbtype'];
> > > 	$dbhost = $pnconfig['dbhost'];
> > > 	$dbuname = $pnconfig['dbuname'];
> > > 	$dbpass = $pnconfig['dbpass'];
> > > 	$dbname = $pnconfig['dbname'];
> > > 	$system = $pnconfig['system'];
> > > 	$encoded = $pnconfig['encoded'];   
> > > }
> > > 
> > > to
> > > if(!isset($prefix)) {
> > > 	include_once 'config.php';
> > > 
> > > 	extract($pnconfig);
> > > }
> > > 
> > > It basically does the same thing with less lines of code and it looks
> > cleaner 
> > > to me. It also seems to work just as well as the old way. :-)
> > > 
> > > Thanks,
> > > Jay
> > I tired this and it did not work on RC9. install.php then showed up as
> > blank.
> > 
> > Zoom
> 
> hhhmmm.... Weird.... Maybe it's my setup then. :-) I'll do some more testing 
> then...
> 
> Jay
> 
Please do cause anything that reduces code is a good thing

Zoom