Re: [PATCH] Updated patch for -pass-header correct handling

Thanks for the patches.

The existing -pass-header implementation works as intended.  To pass the
HTTP_AUTHORIZATION header, you have to specify "-pass-header
HTTP_AUTHORIZATION (not "-pass-header AUTHORIZATION").  I've clarified the
docs a bit.

Consistent with mod_cgi, I have incorporated support for duplicate
Status/Location/ContentType headers being returned by the application.

Rob

> -----Original Message-----
> From: fastcgi-developers-bounces+robs=saccoccio.org-xGejAJT2w6xVgU18Zptdi0EOCMrvLtNR@public.gmane.org
> [mailto:fastcgi-developers-bounces+robs=saccoccio.org-xGejAJT2w6xVgU18Zptdi8XXUOn6P5/[email protected]]
> On Behalf Of Christian Seiler
> Sent: Thursday, August 28, 2008 12:51 AM
> To: fastcgi-developers-xGejAJT2w6xVgU18Zptdi0EOCMrvLtNR@public.gmane.org
> Subject: [FASTCGI] [PATCH] Updated patch for -pass-header correct handling
> 
> Hi,
> 
> I was contacted about my patch for correctly handling the -pass-header
> option [1]. It turns out that my patch didn't work with Apache 1.3 - I
> just updated it so that it works with Apache 1.3, too.:
> 
> http://www.christian-seiler.de/temp/mod_fastcgi-patches/pass-headers.patch
> 
> And I somehow can't find my followup posting in the public archives, so
> I'll repost the patch for the other issue I had with mod_fastcgi, for
> anyone who's interested:
> 
> > Also, I discovered another issue with mod_fastcgi: If a CGI script sends
> > two 'Status: ' headers, mod_fastcgi will cause an internal server error.
> > Yes, it may not be a very good idea to send two status lines BUT a) the
> > CGI specification does not forbid it explicitely and b) Apache does not
> > complain when this happens with normal CGI scripts. As I see no reason
> > to enforce such strictness (Apache with normal CGI doesn't, lighttpd
> > with FastCGI doesn't) and I came across a few scripts that caused this
> > kind of problem with mod_fastcgi, here's a patch that removes the
> > duplicate header check:
> > http://www.christian-seiler.de/temp/mod_fastcgi-patches/duplicate-
> allowed.patch
> 
> Regards,
> Christian
> 
> [1] <http://article.gmane.org/gmane.comp.web.fastcgi.devel/2425>
> _______________________________________________
> FastCGI-developers mailing list
> FastCGI-developers-xGejAJT2w6xVgU18Zptdi0EOCMrvLtNR@public.gmane.org
> http://mailman.pins.net/mailman/listinfo.cgi/fastcgi-developers