Re: apache 2.2+fastcgi+cgicc

Thanks.  Committed.

A new snap is now available: http://fastcgi.com/dist/

Rob


> -----Original Message-----
> From: Tom Donovan [mailto:[email protected]]
> Sent: Monday, September 22, 2008 8:13 AM
> To: fastcgi-developers-xGejAJT2w6xVgU18Zptdi0EOCMrvLtNR@public.gmane.org
> Cc: Rob Saccoccio
> Subject: Re: [FASTCGI] apache 2.2+fastcgi+cgicc
> 
> Rob Saccoccio wrote:
>  > Thanks for the patch.  Committed.
>  >
>  > Rob
> ...
>  >> Apache 2.2.9 included APR 1.3, which introduced an incompatible change
> to
>  >> the way processes are
>  >> created on Windows.  You will need to change mod_fastcgi and rebuild
> it
>  >> for Apache 2.2.9 or higher.
>  >>
>  >> Starting with Apache 2.2.9, it is necessary to call
> apr_procattr_io_set()
>  >> to correctly configure
>  >> stdin, stdout, and stderr for fastcgi programs before calling
>  >> apr_procattr_child_in_set().
> 
> 
> Your patch for Win32 in mod_fastcgi-SNAP-0809220636 doesn't work because
> of the test for the APR
> version numbers:
> 
>       #if (APR_MAJOR_VERSION >= 1) && (APR_MINOR_VERSION >= 3)
> 
> You will need to include apr_version.h (when APACHE2 and WIN32 are both
> defined) for this.
> Your patch works OK with Apache 2.2.9 with the following change.
> 
> -tom-
> 
> --- fcgi_pm.c	2008-09-21 11:38:10.000000000 -0400
> +++ fcgi_pm.c	2008-09-22 08:05:32.398419400 -0400
> @@ -32,6 +32,7 @@
>   #ifdef WIN32
>   #ifdef APACHE2
>   #include "mod_cgi.h"
> +#include "apr_version.h"
>   #endif
>   #pragma warning ( disable : 4100 4102 )
>   static BOOL bTimeToDie = FALSE;  /* process termination flag */
> 
> 
>