Re: minor debugger improvements
Greg Amerson <[email protected]> Tue, 11 Jun 2013 15:22:55 +0800
| Newsgroups | gmane.comp.web.freemarker.devel |
|---|---|
| Message-ID | <CANwu30efmvq0zfOZCTZj01kfCazK5NwuXV5Y3S+GCi7ObVGR3A@mail.gmail.com> |
Hey Daniel, Actually take another quick look at my latest commit here: https://github.com/gamerson/freemarker/commit/92873816c0f628335998aaa92d8cf10c8f26fd77 You will notice that I had to modify one class in the core patch, DebugBreak. I needed to be able to pass the template name to the EvironmentSuspendedEvent object so that on the client I can differentiate between two remote templates that have breakpoints on the exact same line. So I hope this minor change to core can still be merged. Also, Attila got my CLA, so I guess we can move forward. :) G On Mon, Jun 10, 2013 at 5:47 PM, Daniel Dekany <[email protected]> wrote: > Monday, June 10, 2013, 5:40:37 AM, Greg Amerson wrote: > > > Hey freemarker devs, > > > > I've got an open pull request going here: > > https://github.com/freemarker/freemarker/pull/5 > > > > Basically I need a few minor improvements to current debugging > > support in freemarker 2.3.x to support a new client I'm writing for > > Liferay IDE. I'd like to get the project leaders thoughts on what > > remaining tasks are necessary for us to accomplish to get the changes > merged. > > Nothing, as it only affect the debug package. I'm just waiting for the > CLA to arrive with traditional mail, but if there's any urgency with > this, I don't have to wait. Is there? > > -- > Thanks, > Daniel Dekany > > > > > Thanks! > > > > ------------------------------------------------------------------------------ > How ServiceNow helps IT people transform IT departments: > 1. A cloud service to automate IT design, transition and operations > 2. Dashboards that offer high-level views of enterprise services > 3. A single system of record for all IT processes > http://p.sf.net/sfu/servicenow-d2d-j > _______________________________________________ > FreeMarker-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freemarker-devel > -- Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ FreeMarker-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freemarker-devel