Re: minor debugger improvements
Daniel Dekany <[email protected]> Sun, 16 Jun 2013 19:43:55 +0200
| Newsgroups | gmane.comp.web.freemarker.devel |
|---|---|
| Message-ID | <[email protected]> |
BTW, is it possible to make stepping (and break points) not confined to line-starter instructions? Like is that even supported by Eclipse? -- Thanks, Daniel Dekany Tuesday, June 11, 2013, 9:22:55 AM, Greg Amerson wrote: > Hey Daniel, > > Actually take another quick look at my latest commit here: > > https://github.com/gamerson/freemarker/commit/92873816c0f628335998aaa92d8cf10c8f26fd77 > > You will notice that I had to modify one class in the core patch, > DebugBreak. I needed to be able to pass the template name to the > EvironmentSuspendedEvent object so that on the client I can > differentiate between two remote templates that have breakpoints on the exact same line. > > So I hope this minor change to core can still be merged. Also, > Attila got my CLA, so I guess we can move forward. > > G > > > On Mon, Jun 10, 2013 at 5:47 PM, Daniel Dekany <[email protected]> wrote: > Monday, June 10, 2013, 5:40:37 AM, Greg Amerson wrote: > >> Hey freemarker devs, >> >> I've got an open pull request going here: >> https://github.com/freemarker/freemarker/pull/5 >> >> Basically I need a few minor improvements to current debugging >> support in freemarker 2.3.x to support a new client I'm writing for >> Liferay IDE. I'd like to get the project leaders thoughts on what >> remaining tasks are necessary for us to accomplish to get the changes merged. > > Nothing, as it only affect the debug package. I'm just waiting for the > CLA to arrive with traditional mail, but if there's any urgency with > this, I don't have to wait. Is there? > > -- > Thanks, > Daniel Dekany > >> >> Thanks! ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev