Re: CVS personal toolbar wierdness
Tommi Komulainen <[email protected]>
| Newsgroups | gmane.comp.web.galeon.devel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 2003-03-07 at 20:24, Shawn wrote: > That fix you committed... In what files were the fixes to be in? I just > refreshed my copy, and no fix. Here' my copy of Changelog. Ah, you must be using anoncvs.gnome.org, it's pretty slow to update (once a day or something, I think?) The CVS mirror in sourceforge gets the updates more quickly, though it's not a real mirror but a cheap copy. Anyway, here's the fix. -- Tommi Komulainen [email protected] GPG 1024D/68388EE6 6FD6 DD79 EB38 BF6F 3533 09C0 04A8 9871 6838 8EE6
menu-popup.diff
(text/x-patch, 1.9 KB)
Index: ChangeLog =================================================================== RCS file: /cvs/gnome/galeon/ChangeLog,v retrieving revision 1.3499 retrieving revision 1.3500 diff -u -p -r1.3499 -r1.3500 --- ChangeLog 6 Mar 2003 21:17:58 -0000 1.3499 +++ ChangeLog 7 Mar 2003 17:53:25 -0000 1.3500 @@ -1,3 +1,11 @@ +2003-03-07 Tommi Komulainen <[email protected]> + + * utils/gul-gui.c (gul_gui_menu_position_under_widget): Calculate the + popup coordinates using both GdkWindow origin and GtkWidget allocation + coordinates. Fixes bookmarks toolbar folder popping up on the left + edge of the window. (For me at least, hope it doesn't break for + others.) + 2003-03-06 Tommi Komulainen <[email protected]> * mozilla/mozilla-notifiers.cpp: Fix User-Agent to follow mozilla Index: utils/gul-gui.c =================================================================== RCS file: /cvs/gnome/galeon/utils/gul-gui.c,v retrieving revision 1.8 retrieving revision 1.9 diff -u -p -r1.8 -r1.9 --- utils/gul-gui.c 19 Jan 2003 15:21:30 -0000 1.8 +++ utils/gul-gui.c 7 Mar 2003 17:53:27 -0000 1.9 @@ -31,10 +31,6 @@ static void make_selection_list (GtkTreeModel *model, GtkTreePath *path, GtkTreeIter *iter, GList **list); -/* Styles for tab labels */ -GtkStyle *loading_text_style = NULL; -GtkStyle *new_text_style = NULL; - /** * gul_gui_menu_position_under_widget: */ @@ -46,13 +42,13 @@ gul_gui_menu_position_under_widget (GtkM gpointer user_data) { GtkWidget *w = GTK_WIDGET (user_data); - gint width, height; + const GtkAllocation *allocation = &w->allocation; gint screen_width, screen_height; GtkRequisition requisition; - gdk_drawable_get_size (w->window, &width, &height); gdk_window_get_origin (w->window, x, y); - *y = *y + height; + *x += allocation->x; + *y += allocation->y + allocation->height; gtk_widget_size_request (GTK_WIDGET (menu), &requisition);
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQA+aOg2BKiYcWg4juYRAo/yAKDvu15BCANYwFNd6dx63DydbZfADgCglqfy lrQt4H8RNeHNIJKv6+iBgew= =8Z2g -----END PGP SIGNATURE-----