Re: [PATCH] Next/previous tab wraparound

On Mon, 2003-03-31 at 13:58, Juho Snellman wrote:
> The attached patch makes the next/previous tab commands wraparound.
> I.e. if you're already at the last tab and try to move to the next
> one, it goes back to the first tab. This was the behaviour in galeon1.

I'm not sure this is a good idea.  You see, normally in a GtkNotebook
Ctrl+PageDown/PageUp are bound to next/previous tab, and there is no
wraparound.  The menu is used basically for documentation purposes only,
and to make sure the keybindings work even when the notebook itself is
not focused.

If a notebook tab is focused, I think the notebook will handle the
keybindings internally, resulting in no wraparound.  The wraparound
would be working only sometimes, which would only be confusing.


> The patch also fixes a small memory leak that happened when using the
> mentioned commands under some circumstances.

Actually, I think we should be using gtk_notebook_next_page there...


-- 
Tommi Komulainen                                 [email protected]
GPG 1024D/68388EE6    6FD6 DD79 EB38 BF6F 3533  09C0 04A8 9871 6838 8EE6

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+iClRBKiYcWg4juYRAlaOAJ9qWB0HGWs3B2I7L1MxK2t2wQ2TOwCgyV/T
QdyHm3DP78oQq7j/7K72EGY=
=N/mB
-----END PGP SIGNATURE-----